fix(speech): correctly enable and download subtitles for TTS#105
Merged
RyanLee-Dev merged 2 commits intoMiniMax-AI:mainfrom Apr 17, 2026
Merged
fix(speech): correctly enable and download subtitles for TTS#105RyanLee-Dev merged 2 commits intoMiniMax-AI:mainfrom
RyanLee-Dev merged 2 commits intoMiniMax-AI:mainfrom
Conversation
- Fix request parameter: `subtitle` → `subtitle_enable` per official API spec - Fix response parsing: API returns `data.subtitle_file` (URL), not inline `subtitle_info` - Download subtitle JSON from URL and convert to SRT format alongside audio file - Remove dead `SubtitleInfo` type from api.ts - Add dry-run test for `--subtitles` flag - Update skill documentation with subtitle usage examples Fixes MiniMax-AI#102
Newer Bun versions add 'preconnect' to typeof fetch, breaking direct assignment to globalThis.fetch. Cast through any to satisfy TypeScript. This is a pre-existing CI failure, not related to the subtitle fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes `--subtitles` flag for `mmx speech synthesize`, which was not working due to two API spec mismatches.
Root Causes
Changes
How It Works
When `--subtitles` is passed:
SRT Output Example
```
1
00:00:00,000 --> 00:00:05,438
你好,这是第一条字幕。接着是第二句。
2
00:00:05,580 --> 00:00:06,764
谢谢收听。
```
Testing
Closes #102