🐛 fix: add missing category and tool_sign attributes to ParallelExecutorTool - #3481
Merged
Merged
Conversation
…torTool
Bug: MCP tool refresh fails when scanning all tool classes because
ParallelExecutorTool lacks the 'category' attribute that other tools
define (e.g. store_memory uses DATABASE, search_memory uses SEARCH).
Trigger: MCP service refresh iterates over all tool classes and
accesses .category attribute. When it reaches ParallelExecutorTool,
the missing attribute raises AttributeError.
Root cause: ParallelExecutorTool was added as a system-managed tool
without the category and tool_sign class attributes that all other
tools define. The smolagents Tool base class does not provide defaults.
Fix: Set category = None and tool_sign = None on ParallelExecutorTool.
The tool is an orchestration utility (not search/file/email/etc.), so
None is the correct value.
Verification: Called POST /mcp/refresh-tools?mcp_id=1 which returned
{'message': 'Tool count refreshed', 'status': 'success'}. Previously
this would have failed with AttributeError during tool iteration.
Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # sdk/nexent/core/tools/parallel_executor.py
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
WMC001
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MCP tool refresh fails with
AttributeErrorwheniterating over all tool classes. The iteration accesses
.categoryon eachtool, but
ParallelExecutorTooldoes not define this attribute.Root Cause
ParallelExecutorToolwas added as a system-managed tool without thecategoryandtool_signclass attributes that all other tools define(e.g.
store_memoryusesDATABASE,search_memoryusesSEARCH).The
smolagents.Toolbase class does not provide defaults.Fix
Set both attributes to
NoneonParallelExecutorTool. This tool is anorchestration utility that coordinates other agents/tools —it does not
fit into the existing category taxonomy (search/file/email/etc.), so
Noneis the correct value.Verification Screenshot
