Repository navigation
Update github.com/MontFerret/ferret/v2 to v2.0.0-alpha.52 - #47
Merged
Merged
Conversation
…a.52` and add `github.com/ziflex/go-options` as an indirect dependency
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There are build-/diagnostics-impacting issues in the updated harness error path and the web/html module’s glob dependency/version alignment that should be corrected before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the workspace and selected modules in github.com/MontFerret/contrib to use github.com/MontFerret/ferret/v2 v2.0.0-alpha.52, adjusting the runtime harness and module glue code to match upstream API changes.
Changes:
- Bump
github.com/MontFerret/ferret/v2tov2.0.0-alpha.52(plus related indirect dependency updates) across the runtime harness and multiple modules. - Update the runtime harness (
tests/runtime/main.go) and theweb/htmlmodule constructor to align with newer Ferret SDK/module/source/compiler APIs. - Refresh tooling/spec pin (
FERRET_SPEC_VERSION) and related workspace sums.
File summaries
| File | Description |
|---|---|
| tests/runtime/main.go | Align harness flags/source/compiler usage with Ferret alpha.52 APIs and inline module construction. |
| tests/runtime/go.mod | Bump Ferret dependency and related indirects for the runtime harness module. |
| tests/runtime/go.sum | Refresh sums after dependency update. |
| pkg/common/go.mod | Bump Ferret dependency used by shared support package. |
| pkg/common/go.sum | Refresh sums after dependency update. |
| modules/yaml/go.mod | Bump Ferret dependency for YAML module. |
| modules/yaml/go.sum | Refresh sums after dependency update. |
| modules/xml/go.mod | Bump Ferret dependency for XML module. |
| modules/xml/go.sum | Refresh sums after dependency update. |
| modules/web/sitemap/go.mod | Bump Ferret dependency for sitemap module. |
| modules/web/sitemap/go.sum | Refresh sums after dependency update. |
| modules/web/robots/go.mod | Bump Ferret dependency for robots module. |
| modules/web/robots/go.sum | Refresh sums after dependency update. |
| modules/web/html/README.md | Update usage example to match new htmlmodule.New signature. |
| modules/web/html/html.go | Refactor module constructor to return module.Module via sdk.NewModule. |
| modules/web/html/go.mod | Bump Ferret dependency (and should track glob v1 API usage). |
| modules/web/html/go.sum | Refresh sums after dependency update. |
| modules/web/html/drivers/memory/options.go | Update glob pattern typing for new gobwas/glob API. |
| modules/web/html/drivers/cdp/network/interceptor.go | Update glob pattern typing and compilation for new gobwas/glob API. |
| modules/web/article/go.mod | Bump Ferret dependency for article module. |
| modules/web/article/go.sum | Refresh sums after dependency update. |
| modules/toml/go.mod | Bump Ferret dependency for TOML module. |
| modules/toml/go.sum | Refresh sums after dependency update. |
| modules/security/oauth2/go.mod | Bump Ferret dependency for OAuth2 module. |
| modules/security/oauth2/go.sum | Refresh sums after dependency update. |
| modules/security/jwt/go.mod | Bump Ferret dependency for JWT module. |
| modules/security/jwt/go.sum | Refresh sums after dependency update. |
| modules/net/rest/go.mod | Bump Ferret dependency for REST module. |
| modules/net/rest/go.sum | Refresh sums after dependency update. |
| modules/document/xlsx/go.mod | Bump Ferret dependency for XLSX module. |
| modules/document/xlsx/go.sum | Refresh sums after dependency update. |
| modules/document/pdf/go.mod | Bump Ferret dependency for PDF module. |
| modules/document/pdf/go.sum | Refresh sums after dependency update. |
| modules/db/sqlite/go.mod | Bump Ferret dependency for SQLite module. |
| modules/db/sqlite/go.sum | Refresh sums after dependency update. |
| modules/db/redis/go.mod | Bump Ferret dependency for Redis module. |
| modules/db/redis/go.sum | Refresh sums after dependency update. |
| modules/db/postgres/go.mod | Bump Ferret dependency for Postgres module. |
| modules/db/postgres/go.sum | Refresh sums after dependency update. |
| modules/csv/go.mod | Bump Ferret dependency for CSV module. |
| modules/csv/go.sum | Refresh sums after dependency update. |
| modules/archive/options.go | Refactor option validation to go-options builder/validator style. |
| modules/archive/go.mod | Bump Ferret and go-options, plus indirect dependency refresh. |
| modules/archive/go.sum | Refresh sums after dependency update. |
| modules/ai/llm/go.mod | Bump Ferret dependency for LLM module. |
| modules/ai/llm/go.sum | Refresh sums after dependency update. |
| Makefile | Update FERRET_SPEC_VERSION to v1.2.0. |
| go.work.sum | Refresh workspace sums after dependency update. |
Review details
Suppressed comments (1)
tests/runtime/main.go:223
ferret.Newerrors are assigned toe, but the error path prints the unrelatederrvariable, which can hide the real initialization failure (and may print<nil>).
- Files reviewed: 28/48 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a non-existent ferret-spec version pin in the Makefile and also needs a small but important runtime harness error-reporting fix tied to the updated module bootstrap behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 31/51 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+213
to
+216
| html.New( | ||
| html.WithDefaultDriver(memory.New()), | ||
| html.WithDrivers(cdp.New(cdp.WithAddress(*conn))), | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.