Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tools): include trailing output in error briefs and render brief as plain text #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(tools): include trailing output in error briefs and render brief as plain text #2389
Changes from all commits
d74c4fbb280f6dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Shell tool omits tail output in timeout error brief, inconsistent with ACP Terminal
The Shell tool only appends
builder.tail()to the brief for non-zero exit code errors (lines 120-123), but omits it forTimeoutError(lines 128-132). Meanwhile, the ACP Terminal tool (src/kimi_cli/acp/tools.py:145-150) consistently includes the tail in all error cases including timeout. Before theTimeoutErroris raised,stdout_cb/stderr_cbhave already written output to the builder (via_run_shell_commandatsrc/kimi_cli/tools/shell/__init__.py:247-254), sobuilder.tail()would contain useful context about what the command was doing before it timed out.(Refers to lines 128-132)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For commands that emit more than the builder limit before failing (for example a verbose test run that prints >50 KB and then writes the actual failure at the end),
write()has already stopped accepting new data, so scanning_bufferhere returns the tail of the retained prefix rather than the command's real trailing stderr/stdout. Because the shell failure brief now displays this value, users can still miss the actionable error or see misleading context; keep a small rolling tail independently of the capped output buffer before using it in failure briefs.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.