Repository navigation
fix(codemining): do not share a label computation that is over - #394
Merged
Merged
Conversation
The computation was removed from the running ones once completed, by a callback that may run after the caller that waits for it resumed: a computer created right after could share the computation of the previous one, and so not compute the labels again after they expired. Signed-off-by: Hélios GILLES <helios.gilles@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI of master failed on
JumpLabelComputerTest.labels_should_be_computed_again_when_they_expire(expected: <1> but was: <0>), while the previous runs of the same code passed.A computation was removed from the running ones by a callback of the future, which may run after the caller that waits for the future resumed. A computer created right after could then share the computation of the previous one, and so not compute the labels again after they expired.
The computation now removes itself before it completes. The test creates the computers one after the other many times, as the race is rare: I could not make it fail locally on the old code, so the cause is deduced from the code, not observed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GviovNL1A9qQNNC72f312S