Repository navigation
fix(ui): make the settings dialog movable - #728
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe settings dialog now uses the ChangesSettings dialog
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized UI change makes the settings dialog movable and gives it a translated title without changing close, save, or cancel behavior; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #468.
The settings dialog used
StageStyle.UNDECORATED- no native title bar means the OS window manager has nothing to let the user drag, so the window is stuck wherever it opens. On a multi-monitor setup that's always the primary display, exactly as reported.The main launcher window already uses
StageStyle.DECORATED, so this brings the settings dialog in line with that (usingUTILITYinstead - a thinner title bar without minimize/maximize, appropriate for a modal dialog rather than a top-level window). Also set the window title via the existing (already-translated, previously unused)settings_titlelabel key, sinceUTILITY/DECORATEDneed a title to not show a blank bar.No changes to the close/save/cancel behavior - those already close via
getWindow().hide()on the button's own scene, independent of stage style.Test plan:
./gradlew buildsucceeds