Skip to content

Chore: [AEA-0000] - bump dev container version to 1.4.8#97

Open
anthony-nhs wants to merge 1 commit intomainfrom
bump_dev_container_1_4_8
Open

Chore: [AEA-0000] - bump dev container version to 1.4.8#97
anthony-nhs wants to merge 1 commit intomainfrom
bump_dev_container_1_4_8

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

bump dev container version to 1.4.8

Copilot AI review requested due to automatic review settings April 16, 2026 18:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s GitHub Actions pipelines to use a newer revision of the shared eps-common-workflows reusable workflow for devcontainer quality checks, aligning CI behavior with the devcontainer version bump to 1.4.8.

Changes:

  • Bump quality-checks-devcontainer.yml reusable workflow reference to commit 8399c1f... in CI, PR, and release workflows.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/release.yml Updates the reusable devcontainer quality checks workflow SHA used during release.
.github/workflows/pull_request.yml Updates the reusable devcontainer quality checks workflow SHA used on PRs.
.github/workflows/ci.yml Updates the reusable devcontainer quality checks workflow SHA used on merge-to-main CI.

packages: read
quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other referenced reusable workflows in the same file (e.g., get-repo-config.yml, tag-release-devcontainer.yml). Mixing versions can introduce subtle incompatibilities between workflow inputs/outputs; consider bumping all NHSDigital/eps-common-workflows references in this file to the same commit (or add a note explaining why only this one should differ).

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929

Copilot uses AI. Check for mistakes.
packages: read
quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file now uses two different eps-common-workflows commit SHAs (quality-checks-devcontainer.yml vs the other reusable workflows like get-repo-config.yml, pr_title_check.yml, etc.). To avoid version-skew between workflow inputs/outputs and keep upgrades traceable, align all NHSDigital/eps-common-workflows uses: references to the same commit (or document the intentional mismatch).

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml
packages: read
quality_checks:
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only quality-checks-devcontainer.yml was updated to a new eps-common-workflows commit, while other reusable workflows in this file remain pinned to the older commit. If the newer commit changes shared interfaces/outputs, this version skew can break the pipeline; consider bumping all NHSDigital/eps-common-workflows references here to the same commit (or confirm compatibility explicitly).

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc
uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants