Chore: [AEA-0000] - bump dev container version to 1.4.8#97
Chore: [AEA-0000] - bump dev container version to 1.4.8#97anthony-nhs wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s GitHub Actions pipelines to use a newer revision of the shared eps-common-workflows reusable workflow for devcontainer quality checks, aligning CI behavior with the devcontainer version bump to 1.4.8.
Changes:
- Bump
quality-checks-devcontainer.ymlreusable workflow reference to commit8399c1f...in CI, PR, and release workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updates the reusable devcontainer quality checks workflow SHA used during release. |
| .github/workflows/pull_request.yml | Updates the reusable devcontainer quality checks workflow SHA used on PRs. |
| .github/workflows/ci.yml | Updates the reusable devcontainer quality checks workflow SHA used on merge-to-main CI. |
| packages: read | ||
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc |
There was a problem hiding this comment.
This workflow now pins quality-checks-devcontainer.yml to a different eps-common-workflows commit than the other referenced reusable workflows in the same file (e.g., get-repo-config.yml, tag-release-devcontainer.yml). Mixing versions can introduce subtle incompatibilities between workflow inputs/outputs; consider bumping all NHSDigital/eps-common-workflows references in this file to the same commit (or add a note explaining why only this one should differ).
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 |
| packages: read | ||
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc |
There was a problem hiding this comment.
This file now uses two different eps-common-workflows commit SHAs (quality-checks-devcontainer.yml vs the other reusable workflows like get-repo-config.yml, pr_title_check.yml, etc.). To avoid version-skew between workflow inputs/outputs and keep upgrades traceable, align all NHSDigital/eps-common-workflows uses: references to the same commit (or document the intentional mismatch).
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 |
| packages: read | ||
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc |
There was a problem hiding this comment.
Only quality-checks-devcontainer.yml was updated to a new eps-common-workflows commit, while other reusable workflows in this file remain pinned to the older commit. If the newer commit changes shared interfaces/outputs, this version skew can break the pipeline; consider bumping all NHSDigital/eps-common-workflows references here to the same commit (or confirm compatibility explicitly).
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@e798d5aee897de6f7dc387dd5623fcd9ba4c8929 |
bump dev container version to 1.4.8