Skip to content

signzone not failing on missing/invalid key files - #318

Merged
wcawijngaards merged 1 commit into
NLnetLabs:developfrom
jelu:fix-signzone-file-not-exist
Sep 16, 2026
Merged

wcawijngaards merged 1 commit into
NLnetLabs:developfrom
jelu:fix-signzone-file-not-exist

Conversation

@jelu

@jelu jelu commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
  • ldns-signzone: Exit if key file not found or unable to load

- `ldns-signzone`: Exit if key file not found or unable to load
@jelu

jelu commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

This probably also fixes a bug where key can be reused if it first successfully loads a file and later a non-existing one as key is left intact after find_or_create_pubkey().

@wcawijngaards wcawijngaards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to prevent failed zone sign.

@wcawijngaards
wcawijngaards merged commit 6243861 into NLnetLabs:develop Sep 16, 2026
1 of 4 checks passed
wcawijngaards added a commit that referenced this pull request Sep 16, 2026
* PR #318: signzone not failing on missing/invalid key files.
  Thanks Jerry Lundström.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants