Repository navigation
chore(deps): upgrade OpenShell runtime and SDK to 0.1.3 - #12603
Open
nvidia-nemopatch-writer[bot] wants to merge 124 commits into
Open
nvidia-nemopatch-writer[bot] wants to merge 124 commits into
nvidia-nemopatch-writer[bot] wants to merge 124 commits into
Conversation
Patch-Walker-Manifest: sha256:77da0e97a8176f6fde7a669021d9becdafe2ae4deaed1546dfcf152873603b67 Patch-Walker-Action: sha256:7f075ffda8178283fad4ff2b0f7100a86c0b6985c8f59e09fbb6900ab258369c Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
…eipts Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
…e details Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
| try: | ||
| if ipaddress.ip_address(normalized_host).is_loopback: | ||
| return "nemoclaw-managed-inference" | ||
| except ValueError: |
| try: | ||
| if ipaddress.ip_address(normalized_host).is_loopback: | ||
| return "nemoclaw-managed-inference" | ||
| except ValueError: |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Collaborator
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Collaborator
1 similar comment
Collaborator
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Collaborator
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
prekshivyas
added a commit
that referenced
this pull request
Oct 16, 2026
## Outcome The trusted E2E workflow selects reviewed OpenShell supervisor and binary identities for the admitted candidate release. Its MCP resolver recognizes 0.0.116, 0.1.2, and 0.1.3. Both MCP jobs verify the installed CLI, gateway, and sandbox binaries before writing provenance. ## Reason Manual PR E2E uses the workflow from main and checks out the admitted candidate's application source. The two MCP jobs previously pinned 0.0.116 identities, preventing qualification of the approved 0.1.3 upgrade in #12603. This PR prepares that workflow prerequisite. It does not change main's installed or supported OpenShell version. ### Related issues Refs #12603. The application and SDK upgrade remains in that PR. This prerequisite does not change installer selection or the candidate release registry. ## Changes - Extend the existing candidate-version resolver with reviewed supervisor and binary provenance. Candidate source and existing admission determine the selected version; the fixed table does not select or authorize a release. Unknown releases fail before MCP runtime outputs are emitted. - Pass these identities to `mcp-bridge` and `openshell-credential-generation-window`. Verify the three installed binaries selected by the consumer PATH before writing provenance. - Update workflow boundary checks, executable installer tests, and E2E documentation. Retain credential controls, live assertions, cleanup, and target selection. ## Verification Commit under review: `5deb4a18af0e930e1e2b98729a7ac9f9f5b4b947`. - Final affected support tests: 81 passed. Another 107 unchanged support tests passed in the repair batch; these counts do not overlap. - Installed-binary tests cover all three reviewed releases in both jobs and both installation locations. Altering any of the three binaries fails before provenance publication. - Documentation build: 125 routes, zero errors, two warnings. Independent documentation writer review passed for the five repair files. - Normal commit and publication hooks passed, including growth guardrails, compiler checks, and secret scanning. All three published commits are Verified. - [CI](https://github.com/NVIDIA/NemoClaw/actions/runs/38903202115) passed, including all twelve test shards. The CodeRabbit check is successful. Its saved review reports no actionable comments through `f6cfd720`; review coverage of `5deb4a18` is not established. - [Advisor](https://github.com/NVIDIA/NemoClaw/actions/runs/38905730053) completed all nine specialists. Seven were clear; two findings require the disposition below. The aggregate remains failed. ## Review notes The two Advisor findings conflate trusted workflow code with candidate application code: - **Customer value / unconsumed 0.1.3 support:** #12603 is the current consumer. `candidateOpenShellVersion` reads the candidate's installer and runtime inputs and enforces the existing trust/admission path before resolving MCP identities. Main still selects 0.0.116 when it is the candidate. Its existing `ci/openshell-upgrade-trust.json` already contains the 0.1.3 record, contrary to the finding. - **Migration / Docker owner rejects 0.1.x:** both MCP jobs check out `inputs.checkout_sha || github.sha` before executing application code (`e2e.yaml` lines 4101 and 4277 at this commit). The 0.1.3 Docker runtime owner is already in #12603 at `455d598f157a3cce1d8de93cca0f2be16fb338aa`, including `QUALIFIED_STABLE_OPENSHELL_VERSION = "0.1.3"` and the supervisor digest. This source check does not establish live qualification. Changing main's Docker runtime owner here would expand this prerequisite into the upgrade itself. Both findings are recorded as false positives for this prerequisite; no code change or waiver is claimed. Keep this PR draft while the failed Advisor disposition remains unresolved. Full #12603 E2E still requires this workflow fix on main and repairs to the candidate's separate activation failures. Support tests and prerequisite CI do not establish live upgrade qualification. No merge approval is claimed. --- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Reliability** * End-to-end checks for MCP bridge and credential-generation scenarios now use the reviewed OpenShell release selected for the candidate. * Checks verify that the installed OpenShell components match reviewed runtime evidence; unsupported or unverified runtimes stop the checks. * **Tests** * Expanded coverage for runtime verification, workflow configuration, and invalid or mismatched release details. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Collaborator
Collaborator
Collaborator
Collaborator
prekshivyas
marked this pull request as ready for review
October 16, 2026 20:16
Collaborator
Contributor
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Upgrade the pinned OpenShell runtime, supervisor, gateway, and TypeScript SDK to 0.1.3. Preserve legacy volumes without automatic copying.
This PR remains a draft. The conflict-resolution update incorporates main
f1dcab784d, including #13007, #13293, #13335, and #13339. The receipt update is04dad4f06af211f019a53972d453cb5d28ada7ea. Managed-image qualification passed on4dcfbbd06a285ce93dbc9b2623a4327430a3feda; this update records its authenticated Pi receipts. CI must evaluate the receipt update. Full E2E failures and the remaining inference migration still block approval.Reason
OpenShell 0.1.3 changes authentication, provider routing, network mediation, and container lifecycle. The accepted upgrade requires adapting those consumers while preserving ownership and data-safety checks.
Only merged inference changes are incorporated through main. Unmerged inference PRs and separable improvements remain deferred.
Related issues
Refs #12558 for separate inference work. Main changes include #13201, #13284, and #13293. Trusted E2E runtime selection from #13335 and the credentialless inference fixture repair from #13339 are now merged.
Changes
38942952886after the feat(pi): support native local inference #13007 merge.Verification
For receipt update
04dad4f06af211f019a53972d453cb5d28ada7ea:4dcfbbd06a285ce93dbc9b2623a4327430a3feda, including all-agent activation on AMD64, ARM64, and rootless Podman.For the preceding conflict-resolution update:
f1dcab784dand resolved all nine conflicts. Reconciled Pi's private custom endpoint selection with its existing credential handling; the endpoint remains a custom hosted provider.wheel; the rerun used the current user’s group without changing source or assertions. CLI typecheck, reviewed runtime bundle parity, and assertion census passed.38942952886passed; the receipt update above records that qualification.Previous commit evidence
For
53a694dfa08872faf78fa71d55047ea7adfa0844:PR CI and managed-image qualification passed. These results do not qualify the new Pi image inputs.
The latest test-only repair batch passed 108 focused tests: 34 finalization/transfer, 47 privileged cleanup, and 27 hosted-inference support tests. Independent review passed.
Managed image qualification for
5ea4e2773passed Docker AMD64, Docker ARM64, and rootless Podman. Each passed managed-agent activation, external OpenClaw and Hermes rebuilds, image retention, legacy-volume preservation, and cleanup with no failures. This commit changes four test files; production and image inputs match that qualified revision.All 924 tests in 29 affected files passed after the feat(inference): attach OpenClaw local providers #13293 merge. After fix(e2e): select reviewed OpenShell runtime pins #13335, 278 workflow and boundary tests passed. CLI typecheck passed. The stopped-home repair passed 41 additional focused tests.
Normal commit hooks passed for the maintenance/inference repair, main merge, stopped-home cleanup repair, the fix(e2e): select reviewed OpenShell runtime pins #13335 merge, and the fix(e2e): bind credentialless DCode fixture to loopback #13339 fixture repair batch. The assertion budget was lowered to the combined census; no budget exception was added.
Docs validation passed with 125 published routes, 0 errors, and 2 warnings. Independent documentation review covered the merge and both repair groups.
The Pi receipt checker reports
qualifiedagainst this commit. Both existing receipts and their authority match unchanged Pi image inputs.Real stopped-container checks on the retained Brev host passed for Docker and Podman. Both removed sandbox-owned state, preserved protected file content and mode
0600, and removed the owned test containers and volumes.The retained AMD64 Brev Hermes diagnostic used CLI source
8fbe8c4b9and the earlierc75becfaeimage. It passed onboarding, inference, rebuild, post-rebuildPONG, and public destroy. The 8,400,000-byte state file retained its SHA-256 and mode0600; staging was absent, and final sandbox/gateway cleanup was verified. This diagnostic does not qualify the new image inputs.The retained AMD64 Brev OpenClaw diagnostic used CLI source
8fbe8c4b9and the earlierc75becfaeimage. It passed onboarding, inference, rebuild, post-rebuildPONG, and public destroy. The 8,400,000-byte state file retained its SHA-256 and mode0600; staging was absent, and final sandbox/gateway cleanup was verified. fix(e2e): select reviewed OpenShell runtime pins #13335 changed only workflow code, tests, and their README. This diagnostic does not qualify the new image inputs. CI subsequently passed. The supervisor mismatch is resolved by fix(e2e): select reviewed OpenShell runtime pins #13335. The full manual E2E run uses the qualified ancestor image catalog; its failures are recorded below.Managed activation for
c75becfaefailed external rebuild and stopped-Podman cleanup. The repairs above address those observed failures; the failed run does not qualify this commit.An earlier local Hermes turn returned HTTP 401 despite CLI exit 0. Its archive-preservation result remains valid, but its inference result was a failure. Later diagnostics check response content explicitly.
Current E2E findings
Full default manual PR E2E tests commit
53a694dfa08872faf78fa71d55047ea7adfa0844with trusted workflow/base9edf19440e6b6108ae97dfa9d591a66e293a870band qualified ancestor images5ea4e2773. Its dispatch receipt is verified. The OpenShell 0.1.3 gateway authentication test and cleanup passed. The run completed with 52 failed, 31 passed, and 19 skipped jobs. It does not qualify the current candidate.openshell inference get. The pinned 0.1.3 CLI removes that command. Epic [Epic] Complete pre-work for the OpenShell 0.1.2 upgrade #12558 assigns managed-route retirement to Slice 5 after the remaining supported selections have native paths. This is a qualification dependency; unmerged inference changes remain outside this PR.nemoclaw-mcp-v1profile. Config export and runtime-identity checks also failed. Their causes, affected assertions, and cleanup evidence are still under investigation.Earlier evidence
Managed activation for
455d598fpassed managed-agent phases on all three platforms, then failed external-image Hermes inference. The local repairs address that failure; the old run does not qualify this commit. Its PR CI identified the stale fixtures and pending Pi receipt authority.Earlier macOS subprocess failures caused by the Homebrew pinned-install trust refusal remain recorded. Linux results do not establish macOS success.
Review notes
Advisor for
53a694dcompleted all nine specialists. Seven were clear. The custom-provider documentation finding is corrected in this update. The remaining local-inference migration finding stays open: Pi support is now integrated from feat(pi): support native local inference #13007, while Hermes fix(hermes): preserve issued native-local credential references #13292 and the remaining shared-route selections still need their accepted migration work.Advisor for
4dcfbbdwas skipped after source CI failed. No specialist approval is claimed. Source CI failed on stale Pi receipts and two test shards, including snapshot-transfer timeouts. The receipt update addresses the stale receipts; current CI must establish the remaining results.Sensitive paths include installer trust, authentication, provider selection, native mediation, configuration integrity, backup/restore, volume preservation, and destruction. Independent human review remains required.
E2E approvals and dispatches have standing maintainer authorization. That authorization does not waive qualification or authorize merge.
Deferred: unmerged inference integration, shard-load performance optimization, inherited Pi npm advisory investigation, nonblocking hostname-comment cleanup, optional-policy Python-path review, and unrelated unused helpers.
The archive-transfer repair is required for this upgrade's rebuild contract. Existing restore, security, and cleanup assertions remain in place.
Documentation Writer Review
docs-updated38942952886passed for source4dcfbbd; authenticated receipt review and 72 focused tests passed. Full manual E2E failed and remains under investigation.Signed-off-by: Prekshi Vyas prekshiv@nvidia.com