Repository navigation
ci: run the live suites from the test archive - #12973
Merged
Merged
Conversation
Collaborator
Author
|
Hosted run on
|
Collaborator
Author
|
Correction to the table above: whole-job times mix in run-to-run variance inside the suites. AMD64 Kind's image build inside Docker took 89 s here and 57 s before, for example. Measured from job start until the suite starts, setup dropped from 107–128 s to 14–35 s, a saving of 75–106 s per live job. The one exception is ARM64 Kind, at 152 s because of its 117-second download. I've updated the description to match. |
# Conflicts: # .github/workflows/native-platform.yml # docs/contributing/testing.md
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-12973.docs.buildwithfern.com/nemoclaw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Each live job compiles the workspace's test executables again, although
Build and testalready built and archived the same commit's tests for the lifecycle shards. Before compiling, each job also restores the Rust cache and compilesnemoclaw-buildto decide whether the pull request can affect it. With #12970, live jobs set when the LinuxTest / PLATFORMchecks finish, so this repeated work delays required checks:In the last warm
v1run (38070042632), each live job spent 107–128 s before its suite started:cargo ci build: 63–95 s.Decision
Run the live suites the way the lifecycle shards already run:
cargo ci archivealso packs the test executables thelive-dockerandlive-kindnextest profiles select. Selection still comes from the profiles, so there's no second list to maintain. Other platforms archive only the lifecycle suite.ci live-dockerandci live-kindaccept--archive-file, likeci lifecycle.--partitionstays lifecycle-only.Build and testrunsnemoclaw-build changes live, since it already has the build tool compiled. Live jobs skip when the change can't affect them, so they no longer start a runner just to decide.Build and testandBuild bundle, then downloads both artifacts. It runs.build/ci/nemoclaw-build ci SUITE --archive-file, with no Rust setup and no compiling. It restores the downloads cache read-only, for Kind's pinned tools.In the last four warm
v1runs, LinuxBuild and testfinished 9–110 s beforeBuild bundle. This change adds a few seconds toBuild and test(a larger archive and the decision step), so occasionally the live jobs may start a few seconds later.Validation
live-docker --partition.v1, 293 MB now, mostlynemoclaw-build's andnemoclaw-runtime's test executables.cargo cipassed in 523 s: 1,329 workspace tests and 128 lifecycle tests.actionlintpasses.run-live/push of this commit passed (38085576274). Setup before each suite dropped to 14–35 s, from 107–128 s, except one 117-second artifact download on ARM64 Kind. Whole live jobs vary more than that from run to run; see the comment below.