fix(providers): stabilize provider environment revisions - #4122
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The initial review found no blocking issues in the profile revision hashing fix and its regression tests. This is a focused fix for #3929; E2E coverage is still required before the testing handoff is complete.
Blocking findings: No blocking findings remain.
Carried findings: None.
Gator metadata
- Validation: Focused gateway provider revision correctness fix for #3929, authored by a verified maintainer.
- Docs: No new user-facing configuration or workflow; existing behavior is restored.
- Checks: Branch Checks, Helm Lint, Trivy Changes, DCO, and vouch checks passed on the current head.
- E2E: Applied test:e2e; the earlier run skipped runtime suites. Awaiting E2E Label Help instructions and current-head runtime dispatch.
- Head SHA:
01028980b10184ed824699844512a91fc0bbb599 - Base SHA:
36819f476d14e59f29fa6e50ef6c829976ac41d0 - Merge base SHA:
6e369f23964ad7c5a1cbc243340cfb723dd263f4 - Patch ID:
5280512fd0f35430a22d6b2f34323febf6c544be - Gator payload:
10 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
|
Label |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: The existing current-head review found no blocking findings, and the PR reached I removed the active Gator metadata
|
Summary
Make provider profile revision hashing independent of protobuf map iteration order. Multiple profile annotations previously caused an unchanged sandbox's provider environment revision to change between polls, preventing stable credential installation.
Related Issue
Closes #3929
Changes
Testing
cargo test -p openshell-server --lib provider_profile_sources::tests::(45 passed)cargo test -p openshell-server --lib annotated_profile_has_stable_provider_environment_revisioncargo clippy -p openshell-server --lib --tests -- -D warningscargo fmt --all -- --checkChecklist