fix(server): sort map fields when hashing provider profiles - #4077
ericcurtin wants to merge 1 commit into
Conversation
Fixes NVIDIA#3929 Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox ( |
|
@drew @krishicks PTAL when you get a chance, and |
|
/ok to test 475e7dc |
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The independent review found no blocking issues in the provider-profile hashing fix. It canonicalizes profile maps at all four revision hash sites and preserves the existing policy-rule encoding.
@ericcurtin, I checked your request to run tests and posted /ok to test for the current head. Branch Checks, Helm Lint, and E2E are now running; Trivy is green. The E2E run was created after test:e2e was applied, so the bot's rerun hint is satisfied by this fresh run with the label set.
Blocking findings: None.
Carried findings: None.
Non-blocking suggestions: None.
Gator metadata
- Validation: Focused deterministic-revision bug fix for #3929, confined to core encoding and server hash sites.
- Docs: Not needed; restores stable revisions without changing configuration, APIs, or documented workflows.
- Checks: Current-head Branch Checks and Helm Lint running; Trivy passed; DCO and vouch passed.
- E2E:
test:e2eapplied; current-head Branch E2E Checks run 37036927542 running. - Head SHA:
475e7dce921c630e3aba9214c823ebea5432ae9e - Base SHA:
348a1fc62566892ba5530ac9f35acc983e4d9324 - Merge base SHA:
348a1fc62566892ba5530ac9f35acc983e4d9324 - Patch ID:
0ab08d72dcc9575afcce6f95a5de65a5ce7ee4c4 - Gator payload:
10 - Review mode:
initial - Previous reviewed SHA:
none - Review budget exhausted:
no - Maintainer decision required:
no - Next state:
gator:watch-pipeline
|
Superseded by #4122. Closing. |
Monitoring CompleteMonitoring is complete because this PR was closed without merge. @ericcurtin, I checked your closure note that this work is superseded by #4122 and confirmed that #4077 is closed. The existing current-head Gator review found no blocking issues; Branch Checks, Helm Lint, Trivy, and E2E passed. Monitoring of #4122 is outside this invocation's scope. I am removing the active Gator metadata
|
Summary
Provider profile revisions hashed raw protobuf bytes, which vary with map order. Hash a canonical encoding instead.
Related Issue
Fixes #3929
Changes
canonical_provider_profile_bytes, sharing the endpoint map handling withcanonical_rule_bytes(its output is unchanged).Testing
mise run pre-commitpassesChecklist