feat(providersv2): add path auth_style#1622
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
|
Note that adding this path Bearer, header, and query injection all work transparently - the proxy adds a header or query param to the outbound request without the sandbox process needing to know the credential. Path injection is different as the credential is embedded in the URL the process constructs (e.g. Telegram /bot/sendMessage). If the process doesn't have credentials in it's environment, it probably can't construct the URL. A couple ideas:
We may want to figure this out before merging here, to make sure that this approach even works with the v2 providers design |
|
I would lean option 1. On that note, I think we should require the placeholder i.e. The user-facing docs also need to be updated with the path support and indicate what requirements there should be in the path template. |
| pub query_param: String, | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub refresh: Option<CredentialRefreshProfile>, | ||
| #[serde(default)] |
There was a problem hiding this comment.
should this be #[serde(skip_serializing_if = "String::is_empty")] or is it necessary to always be serialized?
|
bump @Cali0707 if you still plan on making changes here |
PR Review StatusValidation: This PR is project-valid because it is concentrated Providers v2 schema/validation work and is linked to roadmap issue #896. Review findings:
Docs: Missing for a direct user-facing provider profile schema change; maintainer feedback also requested docs. E2E labels: No Checks: Branch Checks and Helm Lint are pending on the copy-pr mirror. I am not posting Next state: |
Summary
While looking through the proposal in #896 I saw that we never added the
auth_style: paththat was outlined. This PR looks to close that gapRelated Issue
Part of #896
Changes
path_templatetoCredentialProfilein protobuf and associated typesauth_style: pathvalidationTesting
mise run pre-commitpassesChecklist