Skip to content

test(conformance): cover sandbox lifecycle in archives - #3375

Merged
elezar merged 3 commits into
mainfrom
codex/tmachine-nextest-lifecycle
Sep 17, 2026
Merged

elezar merged 3 commits into
mainfrom
codex/tmachine-nextest-lifecycle

Conversation

@elezar

@elezar elezar commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Add driver-agnostic sandbox lifecycle coverage to the conformance nextest archive. The archive runs smoke and lifecycle targets inside the provisioned t-machine guest; this PR is stacked on #3372.

Related Issue

Related to #2973, #2974, and #2976 through #3371 and #3372. No issue is closed independently by this stacked test-coverage increment.

Changes

  • Add a lifecycle scenario that verifies stop/start workspace preservation and deletion of a stopped sandbox.
  • Add a separately selectable lifecycle nextest target to the conformance CLI suite.
  • Rename the t-machine guest suite and playbook from smoke to conformance.
  • Configure the guest CLI local gateway entry once during scenario installation, before the archived conformance tests run.

Testing

  • cargo test -p openshell-conformance
  • nix run .#build-artifacts-test-archives packages smoke and lifecycle targets
  • nix build .#tmachine-config --no-link
  • Ansible syntax checks for the t-machine gateway and conformance playbooks
  • nix run .#tmachine -- test ubuntu-docker-rootful conformance
  • nix run .#tmachine -- test fedora-podman-rootless conformance
  • nix run .#tmachine -- test fedora-podman-rootful conformance

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar
elezar added this pull request to stack #3374 September 16, 2026 12:43
Base automatically changed from codex/tmachine-nextest-artifacts to main September 16, 2026 13:10
@elezar
elezar removed this pull request from stack #3374 September 16, 2026 13:20
@elezar
elezar force-pushed the codex/tmachine-nextest-lifecycle branch 9 times, most recently from 13ccab7 to fee557e Compare September 17, 2026 12:36
@elezar
elezar added this pull request to stack #3407 September 17, 2026 13:10
@elezar
elezar force-pushed the codex/tmachine-nextest-lifecycle branch 2 times, most recently from f625e07 to a6c7249 Compare September 17, 2026 14:30
SDAChess
SDAChess previously approved these changes Sep 17, 2026

@SDAChess SDAChess left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks but overall looks good

Comment thread tests/ansible/playbooks/gateway.yaml Outdated
Comment thread tests/ansible/playbooks/conformance/cli.yaml Outdated
Comment thread tests/ansible/playbooks/conformance/cli.yaml
@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the codex/tmachine-nextest-lifecycle branch from 4cb2385 to 84d7308 Compare September 17, 2026 15:15
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the codex/tmachine-nextest-lifecycle branch from 4611146 to 8002980 Compare September 17, 2026 15:30
@elezar
elezar added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit af4b200 Sep 17, 2026
57 checks passed
@elezar
elezar deleted the codex/tmachine-nextest-lifecycle branch September 17, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants