Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4107.docs.buildwithfern.com/openshell |
elezar
marked this pull request as ready for review
October 2, 2026 08:56
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 2, 2026 08:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Podman driver suites currently assume the binary installer's CLI path, HTTP registration, configuration file, and system service. Reuse the installed gateway's context so the same suites preserve HTTPS client credentials and target the correct configuration and service when run against native packages. Switch the three Fedora driver-specific branch lanes to RPMs.
Related Issue
No issue required: scoped test-harness maintenance fixes installer assumptions in existing qualification suites; product behavior and public APIs are unchanged. Builds on the package qualification work merged in #4025 and #4056.
Changes
auto,keep-id, and explicit private UID/GID mapping coverage in rootful and rootless modes. Resolve the rootless E2E socket/UID and use the installed gateway's network name.Testing
mise run pre-commitpasses (the unrelated, untrackedpr-issue-summary.mdwas temporarily kept outside check inputs).mise run test:tmachine-gateway: eight tests pass; dedicated Ruff format/lint checks pass.git diff --check.auto,keep-id, and explicit private mappings, healthy gateway readiness after config changes, and system-service journal collection. Candidate binaries were extracted from the existing DEB artifact and supplied explicitly to the normal binary installer in a temporary validation config.driver-podman/e2e-podmannextest archive runs: candidate RPMs and those archives were absent locally. The fixture checks above capture direct Podman mappings and verify gateway configuration loading, but do not run the missing archive's OpenShell-versus-reference comparisons.Full local CI was attempted. After using the existing Nix Z3 library via
LIBRARY_PATH,mise run cireached the Rust tests and stopped in five existingopenshell-driver-vmtests becausemke2fs/mkfs.ext4(e2fsprogs) are unavailable on this host. Full CI is not reported as passing.Checklist