fix(policy): require full binary scope when enabling uninspected credentials - #4171
Open
ericcurtin wants to merge 1 commit into
Open
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
…entials Closes NVIDIA#3942 Signed-off-by: Eric Curtin <eric.curtin@docker.com>
ericcurtin
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 3, 2026 21:14
Contributor
Author
|
If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox ( |
Contributor
Author
|
@mrunalp @johntmyers PTAL when you get a chance, and |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enabling
allow_uninspected_credentialson a shared endpoint now requires naming every binary in the rule, like the other endpoint flags.Related Issue
Closes #3942
Changes
allow_uninspected_credentialsto the endpoint coverage check inopenshell-policy, so the "also declare" guard sees it.policy_covers_rule.Testing
cargo fmt,cargo clippy -D warningsandcargo testforopenshell-policy;cargo testforopenshell-clilib. The new tests fail without the fix.openshell-servertests were not run (no local Z3).Checklist