Repository navigation
Conversation
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The initial review found no blocking issues in the upload destination fix. The existing CI gates pass, and the standard E2E suite is now queued for this head after applying test:e2e and rerunning the workflow as instructed by E2E Label Help.
Blocking findings: None.
Carried findings: None.
Gator metadata
- Validation: Focused fix for the reproducible single-file upload bug in #4175.
- Docs: Published sandbox documentation and CLI help explain destination placement.
- Checks: DCO, Branch Checks, Helm Lint, and Trivy Changes pass on the current head.
- E2E:
test:e2eapplied; Branch E2E Checks run 37198134708, attempt 2, confirmed queued. - Head SHA:
67b0f8024477411a0ce7eadcca711c40846f8abb - Base SHA:
71c3cd957abef062eb7f37010056717cd49f2ed3 - Merge base SHA:
71c3cd957abef062eb7f37010056717cd49f2ed3 - Patch ID:
f9a4959b6b75ca9c0f89635e2590fcb1b0a0c74b - Gator payload:
10 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
|
@shiju-nv this will need a rebase etc |
Inspect remote destination types before choosing archive entry names. Keep directory and source symlinks intact, recheck detected type changes, and report the resulting path. Add real tar and live conformance coverage. Closes NVIDIA#4175 Signed-off-by: Shiju <shiju@nvidia.com>
67b0f80 to
9b368ee
Compare
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Thanks @johntmyers for flagging the rebase. I checked the updated head against the prior reviewed patch, isolated the author changes from upstream changes, and confirmed the upload reporting still works with the new shared planning helper. The independent follow-up review found no new blocking issues, and GitHub reports the head is mergeable.
Branch Checks and the standard E2E suite are running on the current head. Gator will monitor their results before handing this to a maintainer for approval.
Blocking findings: None.
Carried findings: None.
Gator metadata
- Validation: Focused single-file upload destination fix for #4175.
- Docs: Published sandbox docs and CLI help describe destination placement.
- Checks: DCO, Helm Lint, and Trivy Changes pass; Branch Checks are pending.
- E2E:
test:e2eretained; current-head Branch E2E Checks run 37581339905 is in progress, attempt 1. No additional dispatch is needed. - Head SHA:
9b368eed43c74e2be61dbc7e998a38f35b0b7908 - Base SHA:
834b79a8c2351370e7c6c363423f5be18d440256 - Merge base SHA:
834b79a8c2351370e7c6c363423f5be18d440256 - Patch ID:
02746674f19bdf554a7f3808c22f469f7618eb66 - Gator payload:
10 - Review mode:
follow_up - Previous reviewed SHA:
67b0f8024477411a0ce7eadcca711c40846f8abb - Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
Summary
Uploading a single file to an existing directory now puts the file inside it, even without a trailing slash. Previously, the upload could report success after replacing an empty directory with the file. Missing destination paths still support intentional filename renames.
Related Issue
Closes #4175
Changes
Testing
Checklist