fix(sandbox): cut executable identity hashing cost

[ericcurtin]

Summary

Hash each executable once per identity lookup and optimize sha2 in dev builds, so broker tests stop timing out.

Related Issue

Closes #4149

Changes

• Reuse digests computed earlier in the same lookup.
• Set sha2 to opt-level = 3 in the dev profile.

Testing

• Checks appropriate to the affected code and behavior pass
• Unit tests added/updated (if applicable)
• E2E tests added/updated (if applicable)

cargo test -p openshell-binary-identity and cargo test -p openshell-sandbox --lib pass. With software sha2 forced, one hashing test takes 2.55s on main, 1.32s with dedupe, 0.04s with both.

Checklist

• Follows Conventional Commits
• Commits are signed off (DCO)
• Architecture docs updated (if applicable)

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[ericcurtin]

If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox (--sandbox openshell). Thank you!

[ericcurtin]

@derekwaynecarr @johntmyers PTAL when you get a chance, and /ok to test 987ddb6817c2ac82e65e228e83c6f14fc770e3f6 if it looks good. Thank you!

[johntmyers]

/ok to test 987ddb6

[github-actions]

Label test:e2e applied for 987ddb6. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

[johntmyers]

gator-agent

PR Review Status

No blocking findings remain. This focused change reuses executable digests within one identity lookup while retaining snapshot validation before shared-cache publication, and optimizes SHA-256 in development builds.

Thanks @ericcurtin, I checked your request to run tests against the current head and posted the full-SHA /ok to test command after verifying maintainer authority. test:e2e is applied for the sandbox runtime identity path; Branch Checks, Helm Lint, and E2E have started on the current test mirror. The E2E Label Help bot requested a rerun, which GitHub rejected while its first attempt is active. Gator will retry the authorized rerun after that attempt finishes.

Blocking findings: None.
Carried findings: None.
Non-blocking suggestions: None.

Gator metadata

• Validation: Focused sandbox binary identity performance fix for #4149; no competing implementation found.
• Docs: No direct UX or published contract change; Fern updates unnecessary.
• Checks: DCO and vouch passed; Branch Checks queued, Helm Lint and E2E running on the current head. Trivy Changes remains action_required on the fork workflow; its gate has not passed.
• E2E: test:e2e applied; full-current-head /ok to test posted. Results pending. Bot-required rerun not yet queued because the first attempt is active.
• Head SHA: 987ddb6817c2ac82e65e228e83c6f14fc770e3f6
• Base SHA: dfef088bc3d9ecb1b21b5f43e70098eaae3e1a5c
• Merge base SHA: dfef088bc3d9ecb1b21b5f43e70098eaae3e1a5c
• Patch ID: 0d66d0d59e9b9d415e342af39724d0bc92a48698
• Gator payload: 10
• Review mode: initial
• Previous reviewed SHA: none
• Review budget exhausted: no
• Maintainer decision required: no
• Next state: gator:blocked
• Blocked reason: test_dispatch_required

[johntmyers]

If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox (--sandbox openshell). Thank you!

@ericcurtin is it necessary to put this on every PR you have?

[ericcurtin]

@johntmyers No, sorry. I'll only mention it where it's relevant.

[johntmyers]

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: Gator found no blocking findings, and maintainer approval is present. The last active Gator state was gator:approval-needed.

The remaining active gator:* label is being removed because there is nothing left for Gator to monitor on this PR.

Gator metadata

• Head SHA: 987ddb6817c2ac82e65e228e83c6f14fc770e3f6
• Gator payload: 10
• Terminal state: merged