Repository navigation
fix(supervisor): isolate shorthand and OCSF log retention - #4257
Closed
matthewgrossman wants to merge 1 commit into
Closed
matthewgrossman wants to merge 1 commit into
matthewgrossman wants to merge 1 commit into
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4257.docs.buildwithfern.com/openshell |
matthewgrossman
deleted the
fix/4256-independent-log-retention/matthewgrossman
branch
October 6, 2026 22:37
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep supervisor shorthand and OCSF JSONL retention independent by changing the shorthand filename prefix to
openshell-text. JSONL filenames,/var/log, daily rotation, and the three-file limits stay unchanged.Related Issue
Closes #4256
Changes
/v1/denials, while continuing to exclude JSONL files.Testing
Passed locally on macOS:
mise exec -- cargo test -p openshell-supervisor --bin openshell-supervisor --locked -- --nocapture(9 tests)mise exec -- cargo test -p openshell-supervisor-network --lib policy_local::tests --locked(39 tests; also passed with--no-default-features)mise exec -- cargo clippy -p openshell-supervisor -p openshell-supervisor-network --all-targets --locked -- -D warningscargo fmt --check, Markdown lint,mise run docs, andgit diff --check. Fern reported zero errors and three existing warnings.The test filesystem exposes creation timestamps. An isolated copy of the regression test using the original
openshellprefix failed as expected: initializing shorthand reduced three JSONL files to one. A prefix-disjointness assertion also guards the timestamp-unavailable fallback, since filtering precedes either timestamp path. Rollover coverage usesMINUTELYto cross a real boundary within 65 seconds; it exercises the same pruning path as production'sDAILYrotation without a dependency patch or mock clock.Checklist