Repository navigation
Conversation
|
Label |
This was referenced Oct 14, 2026
|
Label |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
codex/cdi-name-parser
branch
from
October 15, 2026 15:01
360f6d5 to
01b0b55
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the public upstream CDI predicate on Linux for the name validation introduced in #4306, retaining the existing local checker on other platforms. This moves reusable CDI dependency and vendoring setup out of the resolver work in #4204 without changing accepted selectors or validation errors.
Related Issue
No issue required: internal refactor of the existing validation added in #4306, with no user-facing behavior change.
Follow-up to #4306 (
fix(drivers): validate vendor-agnostic CDI device names); prerequisite for #4204. Includes the Git vendoring support from #4204 commit 4cad83e.Changes
cdi_name::is_qualified_nameentrypoint: directly reexport upstream on Linux and select the unchanged local checker elsewhere. Reuse the existing GPU validation tests.cargo vendoroutput without--quiet, which suppresses the mapping on the current toolchain.Testing
mise run pre-commitpasses.aarch64-unknown-linux-gnuin a minimal check harness.--locked --offlineand empty registry/Git caches. Full-workspace offline dependency resolution also passes with the complete vendor tree and corrected mappings.mise run ci: stops at the unchangedopenshell-supervisor-networktestmediated_connect_keeps_workload_bytes_read_with_the_synthesized_headerwith an upstream-request timeout. An isolated retry of the same workspace test binary passes.Checklist