Skip to content

bug fix: constrain cuda.core test installs to the requested CTK minor #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rwgk wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

bug fix: constrain cuda.core test installs to the requested CTK minor #1921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0730157
test: pin core toolkit installs to the requested CTK minor
rwgk Apr 15, 2026
117e3db
test: simplify core wheel install selection
rwgk Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ci/tools/run-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ elif [[ "${test_module}" == "core" ]]; then

pushd ./cuda_core
CUDA_VER_MINOR="$(cut -d '.' -f 1-2 <<< "${CUDA_VER}")"
if [[ "${LOCAL_CTK}" == 1 ]]; then
# We already installed cuda-bindings, and all CTK components exist locally,
# so just install the test dependencies.
# Constrain cuda-toolkit to match the local CTK version to avoid
# pip pulling in a newer nvidia-cuda-runtime that conflicts with it.
pip install "${CUDA_CORE_ARTIFACTS_DIR}"/*.whl --group "test-cu${TEST_CUDA_MAJOR}${FREE_THREADING}" "cuda-toolkit==${CUDA_VER_MINOR}.*"
else
pip install $(ls "${CUDA_CORE_ARTIFACTS_DIR}"/*.whl)["cu${TEST_CUDA_MAJOR}"] --group "test-cu${TEST_CUDA_MAJOR}${FREE_THREADING}"
# Start from the built wheel path, then add the published cuda.bindings extra
# when this job is resolving against wheel-installed CTK packages.
WHL_EXTRA=("${CUDA_CORE_ARTIFACTS_DIR}"/*.whl)
if [[ "${LOCAL_CTK}" != 1 ]]; then
WHL_EXTRA=("${WHL_EXTRA[0]}[cu${TEST_CUDA_MAJOR}]")
fi
# Constrain cuda-toolkit to the requested CTK version to avoid
# pip pulling in a newer nvidia-cuda-runtime that conflicts with it.
pip install "${WHL_EXTRA[@]}" --group "test-cu${TEST_CUDA_MAJOR}${FREE_THREADING}" "cuda-toolkit==${CUDA_VER_MINOR}.*"
echo "Running core tests"
${SANITIZER_CMD} pytest -rxXs -v --durations=0 --randomly-dont-reorganize tests/
# Currently our CI always installs the latest bindings (from either major version).
Expand Down
Loading