Model Training Example with MACE#109
Open
ys-teh wants to merge 14 commits into
Open
Conversation
83363c2 to
4addb20
Compare
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
837a527 to
bb9efcf
Compare
Contributor
Greptile SummaryThis PR adds an end-to-end MACE model training example (
Important Files Changed
Reviews (7): Last reviewed commit: "address potential reader-close failure" | Re-trigger Greptile |
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
Signed-off-by: Ying Shi Teh <yteh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALCHEMI Toolkit Pull Request
Description
This PR adds an advanced training example for a charged MACE model and the supporting code modifications needed to train it with available ALCHEMI tools.
Note: This can only be merged after #108 is merged.
Type of Change
Related Issues
Changes Made
examples/advanced/10_mace_training.py(along with configexamples/advanced/10_vanilla_mace.yaml) using nvalchemi model training pipeline.examples/advanced/_mace_training_helpers.pywith additional training utilities including stress unit conversion, training loss logging, validation, parameter counting, and gradient clipping hook.examples/advanced/_mace_models.pywith builders for vanilla MACE model, including cuEquivariance config support.docs/userguide/mace_training_example.md.Testing
make pytest)make lint)Run training
Checklist
Additional Notes
Below are NVT and NVE stability results for the trained MACE model on a 324-atom MgVF4 3x3x3 MatPES-r2SCAN test structure. These runs completed all 20,000 steps without numerical instability or force/temperature warnings.
Tip
This repository uses Greptile, an AI code review service, to help conduct
pull request reviews. We encourage contributors to read and consider suggestions
made by Greptile, but note that human maintainers will provide the necessary
reviews for merging: Greptile's comments are not a qualitative judgement
of your code, nor is it an indication that the PR will be accepted/rejected.
We encourage the use of emoji reactions to Greptile comments, depending on
their usefulness and accuracy.