Fix SpectralConvS2 bias with channel projection#220
Open
fallintoplace wants to merge 3 commits into
Open
Conversation
azrael417
requested changes
Jun 18, 2026
azrael417
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but please amend the Changelog as well here. Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spectral_biasby input channels in the serial and distributed spectral convolution layers.SpectralConvS2(bias=True)when input and output channel counts differ.Why
The spectral bias is applied before the grouped channel contraction, while the tensor is still shaped by input channels. It was previously initialized with
out_channels, sobias=Truefailed for channel projections such as 4 -> 8 or 8 -> 4.Keeping the parameter input-channel-shaped preserves the existing pre-contraction bias semantics and keeps equal-channel cases unchanged.
Validation
uv run --no-project --with 'torch>=2.6.0' --with 'numpy>=1.22.4' --with parameterized --with pytest python -m pytest tests/test_spectral_convolution.py -quv run --no-project --with ruff ruff check torch_harmonics/spectral_convolution.py torch_harmonics/distributed/distributed_spectral_convolution.py tests/test_spectral_convolution.py