Update the extension to work in 2023 :) - #7
Open
galaxy4public wants to merge 2 commits into
Open
Conversation
- Collected an applied different patches found across multiple forks of this extension - Updated the code to work with the latest version of Markdown
Updated the extension to work in 2023 :)
galaxy4public
commented
Apr 14, 2023
Author
There was a problem hiding this comment.
Obviously, this file is not applicable to be merged upstream since it points to a fork, but given no activity in @Neepawa's repository I did not want to spend time to split out the changes acceptable vs what is my fork only stuff.
galaxy4public
commented
Apr 14, 2023
Comment on lines
+4
to
+10
| NOTE: This is a fork of an excellent idea implemented by @Neepawa, however | ||
| the upstream seems to be abandoned for a while, so I collected different | ||
| patches across all forks and also updated the extension to work with the | ||
| latest version of [Python-Markdown][markdown]. I plan to maintain this | ||
| version (and push changes to upstream) as long as I am running my personal | ||
| blog on [Pelican][pelican], which heavily relies on Python-Markdown. | ||
|
|
Author
There was a problem hiding this comment.
This block should be deleted if the change is to be accepted since it is a part of my local fork's README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an excellent extension to support the
rowspanandcolspantable functionality in Markdown. However, for some reason, the development/support has stopped somewhere in 2019. I've updated the extension to work with the latest Markdown version (which introduced some incompatible API changes) and also applied bugfixes from forks found in the public repositories.I plan to maintain my version as long as I am using Python-Markdown, but if the upstream resurrects I would gladly, revert to it. In any case, this PR is just to share the work that was done, so people who are interested in the working extension would have an option to use it.