Repository navigation
fix: per-deployment ConfigMap name via ALDAAS_SESSION_ID - #8
Merged
Merged
Conversation
ALDAAS_NAME is the same across all review apps (aldaas-dandelion-app-backend).
In shared namespaces, all pods wrote to the same ConfigMap
aldaas-session-aldaas-dandelion-app-backend, overwriting each other.
Add ALDAAS_SESSION_ID env var: when set, ConfigMap name becomes
aldaas-session-${ALDAAS_SESSION_ID} (e.g. aldaas-session-72536668-review-feature-hr-9oqso9).
Falls back to ALDAAS_NAME if not set (backward compatibility).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ALDAAS_NAMEis the same across all review apps (aldaas-dandelion-app-backend). In shared namespaces, all pods wrote to the same ConfigMapaldaas-session-aldaas-dandelion-app-backend, overwriting each other's workflow names.Fix
Add
ALDAAS_SESSION_IDenv var: when set, ConfigMap name becomesaldaas-session-${ALDAAS_SESSION_ID}(e.g.aldaas-session-72536668-review-feature-hr-9oqso9).Falls back to
ALDAAS_NAMEif not set (backward compatibility).Usage
Set
ALDAAS_SESSION_ID=$CI_PROJECT_ID-$CI_ENVIRONMENT_SLUGin the aldaas container env (HELM_UPGRADE_VALUES_FILE).