Repository navigation
fix: check workflow phase before reusing saved session - #9
Merged
Merged
Conversation
When K8S_SESSION_STORE or /tmp file contains a saved workflow name, argo get may succeed even if the workflow is in Failed/Error phase. This causes the client to hang waiting for a DB Service that will never come up. Now we check the workflow phase and only reuse workflows that are Running or Succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
K8S_SESSION_STORE=true, the aldaas client saves the workflow name to a ConfigMap. On pod restart, it reads the ConfigMap and checksargo get. Ifargo getsucceeds (workflow exists), it reuses the workflow — even if the workflow is inFailedorErrorphase. This causes the client to hang waiting for a DB Service that will never come up.Same bug exists in file mode (
/tmp/aldaas) — the file persists the workflow name, and on restart the client reuses it without checking the workflow phase.Fix
After
argo getsucceeds, also check the workflow phase viaargo get -o jsonpath='{.status.phase}'. If the phase isFailed,Error, or any non-running/non-succeeded state, treat the saved workflow as invalid and re-provision a new one.Applied in both places:
Backward compatible: if jsonpath returns empty (older Argo versions), the workflow is reused as before.