Repository navigation
packaging: Fix more fork unsafety in aws-c-io s2n patch - #16514
Conversation
The are several oopsies I made when rebasing those patches. One is that AWS_USE_SECITEM must not be defined at all. Second one is apparently there's even more fork unsafety... Can't wait to get rid of fork() without exec so that this cursedness is not needed.
|
Let's wait for @Mic92 as the author of original patch. I rushed the first time to get the nixpkgs bumped, but now I'm eyeing bumping nixpkgs on the maintenance branch so it better be correct. |
|
I actually dropped the patch because unstable had now and upstream version doing this by default, if I remember correctly. So maybe bumping could be easier? |
|
@mix92 I was able to reproduce issue even with the new version on my Mac. I can post backtraces here. |
|
Nevermind than, I just noticed during rebase than s2n was linked and didn't checked closely. |
|
If this has urgency please just go ahead. I won't have time to look into it more closely because of nixcon. |
|
Ugh for the lack of a better option, let's go with this for now. At least it no longer crashed... Though I must say I don't feel comfortable patching such core code without fully understanding all the consequences. I'll try to get rid of fork-without-exec ASAP. |
3 participants
Motivation
The are several oopsies I made when rebasing those patches. One is that AWS_USE_SECITEM must not be defined at all. Second one is apparently there's even more fork unsafety...
Can't wait to get rid of fork() without exec so that this cursedness is not needed.
That should be quite easy to do with #16504.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.