Repository navigation
Add more build options for dependent executables - #16564
Merged
Merged
Conversation
github-actions
Bot
added
new-cli
philiptaron
changed the title
xokdvium
reviewed
Oct 5, 2026
xokdvium
reviewed
Oct 5, 2026
Expose the ssh-program build option from libstore as sshProgram(), mirroring gitProgram() in libfetchers, so the Git LFS ssh handshake no longer hardcodes "ssh" from PATH.
The bash-program build option covered nix develop and nix-shell, but nix shell still fell back to a bare "bash" from PATH.
Nix runs some command strings through a POSIX shell. Examples are the pager and ssh LocalCommand. Instead of using a hardcoded /bin/sh, make that path configurable at build time and expose it as shProgram(), like gitProgram() and sshProgram(). It has to be absolute because neither execl nor ssh searches PATH for it.
philiptaron
force-pushed
the
more-build-options
branch
from
October 5, 2026 23:19
9919b5c to
84c15e4
Compare
xokdvium
reviewed
Oct 6, 2026
Run $NIX_PAGER/$PAGER through shProgram() instead of a hardcoded /bin/sh.
The local ssh client runs -oLocalCommand through $SHELL, so point it at shProgram() instead of a hardcoded /bin/sh.
philiptaron
force-pushed
the
more-build-options
branch
from
October 6, 2026 19:17
5d10f94 to
e00e472
Compare
xokdvium
approved these changes
Oct 6, 2026
xokdvium
left a comment
xokdvium
left a comment
Contributor
There was a problem hiding this comment.
Minor note. Otherwise let's proceed to unblock you. I don't necessarily feel strongly about this, but being explicit about such implicit dependencies is good regardless IMO.
xokdvium
approved these changes
Oct 6, 2026
xokdvium
left a comment
xokdvium
left a comment
Contributor
There was a problem hiding this comment.
Minor note. Otherwise let's proceed to unblock you. I don't necessarily feel strongly about this, but being explicit about such implicit dependencies is good regardless IMO.
xokdvium
enabled auto-merge
October 6, 2026 19:40
Contributor
Author
|
NixOS/nixpkgs#1424 is what I was thinking of with
Not planning on fixing these directly, but they're bricks in the wall of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Continues #16110 by adding more helpers for absolute paths Nix relies on.
Context
I'm looking to build a version of Nix which is self-contained.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.