anki: fix build - #437041
Closed
wrvsrx wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the fix, but I think that we should close this in favor of #425219, which also includes it in addition to the version bump. |
Member
|
Thanks for noticing the issue and fixing the build @wrvsrx, appreciated! I'm okay merging this first if we think #425219 will take much longer to merge (though we could cherry-pick the patch file from #425219 to reduce the chance of merge-conflict). If #425219 is able to land soon, I think it's fine to wait on that and avoid one merge conflict. |
Contributor
Author
|
Close it in favor of #425219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently anki fails to build due to rust 1.89. This PR fix it.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.