anki: fix darwin build, add missing platform wheels - #499992
Merged
dotlambda merged 3 commits intoMar 18, 2026
Merged
Conversation
euank
approved these changes
Mar 16, 2026
euank
left a comment
Member
There was a problem hiding this comment.
One style comment which I don't feel strongly about at all, feel free to ignore it either way!
I can't test the darwin build since I don't have a macOS device, but the change makes sense to me, thank you!
tomrfitz
force-pushed
the
anki-darwin-extra-wheels-upstream
branch
from
March 16, 2026 04:11
2d8f998 to
b23e67c
Compare
dotlambda
requested changes
Mar 16, 2026
dotlambda
left a comment
Member
There was a problem hiding this comment.
anki-audio and anki-mac-helper aren't available in python3Packages
Add them to python3Packages instead.
tomrfitz
force-pushed
the
anki-darwin-extra-wheels-upstream
branch
from
March 16, 2026 07:12
b23e67c to
6ce397c
Compare
Contributor
Author
|
Amended and pushed again with your suggested change as i understand it. test build passed on x86_64-linux and here's i haven't worked that in depth before in nixpkgs so that was a fun detour to learn how things work in more detail. |
dotlambda
reviewed
Mar 16, 2026
tomrfitz
force-pushed
the
anki-darwin-extra-wheels-upstream
branch
from
March 16, 2026 18:02
6ce397c to
a5a997c
Compare
dotlambda
reviewed
Mar 16, 2026
tomrfitz
force-pushed
the
anki-darwin-extra-wheels-upstream
branch
from
March 17, 2026 18:54
a5a997c to
3f2e481
Compare
Contributor
Author
|
Pushed again with the two suggested changes:
Open to feedback regarding where to pin |
tomrfitz
force-pushed
the
anki-darwin-extra-wheels-upstream
branch
from
March 17, 2026 22:29
3f2e481 to
7c27d80
Compare
wire newly added anki-audio and anki-mac-helper from python3Packages into pythonDeps
tomrfitz
force-pushed
the
anki-darwin-extra-wheels-upstream
branch
from
March 18, 2026 02:11
7c27d80 to
74db147
Compare
dotlambda
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anki-audio and anki-mac-helper aren't available in python3Packages. uv requires them to build on darwin, but sandboxed builder can't fetch them, so fetch them here and link them alongside other wheels.
This fixes the regression on darwin from #498788 which was missing two darwin-specific, anki-only deps. This is less clean than adding those deps to python3Packages, but since they're only used for anki (afaik) this gets darwin back online more quickly. x86_64-linux build is unaffected in my testing since these wheels are platform gated.
before change: failed build output
without any changes:
after adding fetch for anki-audio wheel:
Full nixpkgs-review output
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.