Repository navigation
windmill: 1.601.1 -> 1.839.0 - #575365
Merged
Merged
windmill: 1.601.1 -> 1.839.0#575365
Conversation
KiaraGrouwstra
marked this pull request as ready for review
October 17, 2026 19:23
Contributor
|
The diff looks good, would be nice if you can run a nixpkgs-review, otherwise will do so when j get time. |
Changelog: https://github.com/windmill-labs/windmill/blob/v1.839.0/CHANGELOG.md Releases before 1.783.0 have CVE-2026-29059. - Regenerate the patches for the new source. - Remove `rust_executor.patch`. Upstream now has a default value when `HOME` is not set. - Remove the `loki` feature, because upstream removed it. - Use the `simdutf` archive of `librusty_v8`, because the `deno` crates enable the `simdutf` feature of `v8`. Update `update-librusty.sh` to get this archive. - Remove the `mold` linker flag of upstream, because `mold` is not in the build environment. - Set `auditable = false`, because `cargo-auditable` gives the features of `windmill` to all workspace members, and `windmill-mcp` refuses `oauth2`. - Set `OPENSSL_NO_VENDOR`, so that the binary links to the `openssl` of nixpkgs and does not contain its own copy of OpenSSL. - Use response files in the cc and ld wrappers, because the link of the `windmill` binary has too many arguments for one `exec`. Assisted-by: Claude:claude-opus-5-5
KiaraGrouwstra
force-pushed
the
windmill-1.839.0
branch
from
October 17, 2026 20:52
529a3c6 to
02b0a9c
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/windmill-labs/windmill/blob/v1.839.0/CHANGELOG.md
Releases before 1.783.0 have CVE-2026-29059, an unauthenticated path traversal in
/api/w/{workspace}/jobs_u/get_log_file/{filename}. This update gets the fix.Changes to the recipe:
rust_executor.patch. Upstream now has a default value whenHOMEis not set.lokifeature, because upstream removed it.simdutfarchive oflibrusty_v8, because thedenocrates enable thesimdutffeature ofv8.update-librusty.shgets this archive.moldlinker flag of upstream, becausemoldis not in the build environment.auditable = false, becausecargo-auditablegives the features ofwindmillto all workspace members, andwindmill-mcprefusesoauth2.OPENSSL_NO_VENDOR. Thessl-vendoredfeature ofrdkafkaenables thevendoredfeature ofopenssl-sys, so without this setting the binary contains its own copy of OpenSSL (3.6.3 in this release). With this setting, the binary links to theopensslof nixpkgs.windmillbinary has too many arguments for oneexec.The binary still contains its own copies of curl (8.22.0, from
curl-syswithcurl-static) and librdkafka (2.12.1, fromrdkafka-syswithcmake-build), as in 1.601.1.Tests:
windmill versiongivesv1.839.0.nixosTests.windmill(passthru.tests) passes on x86_64-linux. I did not build on aarch64-linux and I did not runnixpkgs-review.Patch and description drafted up by Claude, and reviewed by me.
Things done
./result/bin/.nixpkgs-reviewon this PR. See nixpkgs-review usage.passthru.tests.Assisted-by: Claude:claude-opus-5-5
https://claude.ai/code/session_017suXJrdCohj4k1zNZaRkEg