Skip to content

windmill: 1.601.1 -> 1.839.0 - #575365

Merged
happysalada merged 1 commit into
NixOS:masterfrom
KiaraGrouwstra:windmill-1.839.0
Oct 18, 2026
Merged

happysalada merged 1 commit into
NixOS:masterfrom
KiaraGrouwstra:windmill-1.839.0

Conversation

@KiaraGrouwstra

@KiaraGrouwstra KiaraGrouwstra commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Changelog: https://github.com/windmill-labs/windmill/blob/v1.839.0/CHANGELOG.md

Releases before 1.783.0 have CVE-2026-29059, an unauthenticated path traversal in /api/w/{workspace}/jobs_u/get_log_file/{filename}. This update gets the fix.

Changes to the recipe:

  • Regenerate the patches for the new source.
  • Remove rust_executor.patch. Upstream now has a default value when HOME is not set.
  • Remove the loki feature, because upstream removed it.
  • Use the simdutf archive of librusty_v8, because the deno crates enable the simdutf feature of v8. update-librusty.sh gets this archive.
  • Remove the mold linker flag of upstream, because mold is not in the build environment.
  • Set auditable = false, because cargo-auditable gives the features of windmill to all workspace members, and windmill-mcp refuses oauth2.
  • Set OPENSSL_NO_VENDOR. The ssl-vendored feature of rdkafka enables the vendored feature of openssl-sys, so without this setting the binary contains its own copy of OpenSSL (3.6.3 in this release). With this setting, the binary links to the openssl of nixpkgs.
  • Use response files in the cc and ld wrappers, because the link of the windmill binary has too many arguments for one exec.

The binary still contains its own copies of curl (8.22.0, from curl-sys with curl-static) and librdkafka (2.12.1, from rdkafka-sys with cmake-build), as in 1.601.1.

Tests: windmill version gives v1.839.0. nixosTests.windmill (passthru.tests) passes on x86_64-linux. I did not build on aarch64-linux and I did not run nixpkgs-review.

Patch and description drafted up by Claude, and reviewed by me.

Things done

Assisted-by: Claude:claude-opus-5-5

https://claude.ai/code/session_017suXJrdCohj4k1zNZaRkEg

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. llm-assisted Contributions that include code generation with LLMs labels Oct 17, 2026
@KiaraGrouwstra
KiaraGrouwstra marked this pull request as ready for review October 17, 2026 19:23
@happysalada

Copy link
Copy Markdown
Contributor

The diff looks good, would be nice if you can run a nixpkgs-review, otherwise will do so when j get time.

Changelog: https://github.com/windmill-labs/windmill/blob/v1.839.0/CHANGELOG.md

Releases before 1.783.0 have CVE-2026-29059.

- Regenerate the patches for the new source.
- Remove `rust_executor.patch`. Upstream now has a default value when
  `HOME` is not set.
- Remove the `loki` feature, because upstream removed it.
- Use the `simdutf` archive of `librusty_v8`, because the `deno` crates
  enable the `simdutf` feature of `v8`. Update `update-librusty.sh` to
  get this archive.
- Remove the `mold` linker flag of upstream, because `mold` is not in
  the build environment.
- Set `auditable = false`, because `cargo-auditable` gives the features
  of `windmill` to all workspace members, and `windmill-mcp` refuses
  `oauth2`.
- Set `OPENSSL_NO_VENDOR`, so that the binary links to the `openssl` of
  nixpkgs and does not contain its own copy of OpenSSL.
- Use response files in the cc and ld wrappers, because the link of
  the `windmill` binary has too many arguments for one `exec`.

Assisted-by: Claude:claude-opus-5-5
@KiaraGrouwstra

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 575365
Commit: 02b0a9c7c1b57064e4beab0f629eab7d79bbc84b


x86_64-linux

✅ 1 package built:
  • windmill

@happysalada
happysalada added this pull request to the merge queue Oct 18, 2026
Merged via the queue into NixOS:master with commit 88136ad Oct 18, 2026
27 checks passed
@KiaraGrouwstra
KiaraGrouwstra deleted the windmill-1.839.0 branch October 18, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. llm-assisted Contributions that include code generation with LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants