Skip to content

fix(data): add NFC to the Galaxy S10, Note10 and others the wiki missed - #34

Merged
NotAFlightRisk merged 1 commit into
mainfrom
fix/missing-nfc-hardware
Oct 9, 2026
Merged

NotAFlightRisk merged 1 commit into
mainfrom
fix/missing-nfc-hardware

Conversation

@NotAFlightRisk

Copy link
Copy Markdown
Owner

Category

Data (no code)

Overview

The LineageOS wiki leaves NFC off the peripherals list for a fair few phones, and the import copies that straight into hardware. So the S10s, Note10s and co. showed NFC and Google Wallet as n/a on every ROM, which isnt great when they've all got it. This takes 92 active rows off a wrong n/a.

Each one's checked against its LineageOS device tree, since those only ship the NFC stack for phones that have the chip:

  • Galaxy S9, S9+, Note9, the S10s and Note10s - the NFC chip's firmware is in each phone's own proprietary-files.txt (e.g. beyond1lte)
  • Galaxy A52s, M52, A71 and A73 - an NFC flag or NFC HAL in the phone's own tree
  • Galaxy S7, S7 edge, A52 4G, A72, LG G5 and G6 - their common trees turn NFC on for every phone they build (universal8890, sm7125, msm8996)
  • Xperia XZ2, XZ2 Compact and XZ3, Mi 8, Mi 8 Explorer, Mi 8 Pro, nubia Z18, Redmi 9 and Redmi Note 9 - NFC set up in the phone's own device.mk (only the NFC variants, for the Redmis)
  • Galaxy S10, A21s and Nokia 7 plus - GSMArena too (the A21s only has it in some markets)

Issue Number

None

Additional Info

Anything I couldn't back up either way (Mi 8 SE, Mi A3, POCO F1, the other nubias, S8/S8+) is left alone.

Some AI was use when making this

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
android-rom-compat Ready Ready Preview Oct 9, 2026 9:28pm UTC

@github-actions github-actions Bot added the bug Something isn't working label Oct 9, 2026
@NotAFlightRisk
NotAFlightRisk merged commit dd40ed6 into main Oct 9, 2026
12 of 15 checks passed
@NotAFlightRisk
NotAFlightRisk deleted the fix/missing-nfc-hardware branch October 9, 2026 21:47

This branch was successfully deployed

1 active deployment
Preview — 8e1fa133 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant