Repository navigation
[FIX] gen_addon_readme: images in several md fragments - #688
Open
jaydev-CAstra wants to merge 1 commit into
Open
jaydev-CAstra wants to merge 1 commit into
jaydev-CAstra wants to merge 1 commit into
Conversation
Pandoc names the images of each fragment image, image1, ... so two fragments with images produce a duplicate substitution definition and docutils fails. Rename the ones already used by a previous fragment. Fixes OCA#632
MiquelRForgeFlow
approved these changes
Oct 15, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632
Each .md fragment is converted to rst on its own, and pandoc names the images
image,image1, ... in every file. With images in two fragments (DESCRIPTION.md and CONFIGURE.md for instance) the README ends up with two.. |image| image::definitions and docutils fails with "Duplicate substitution definition name", which blocks the merge bot (see OCA/server-tools#3045).Substitutions already defined by a previous fragment are now renamed to the next free name, so READMEs without the problem do not change.