Conversation
5 tasks
5 tasks
5 tasks
Cover modbus.unit_id, modbus.transaction_id, modbus.protocol_id, modbus.function, modbus.subfunction, modbus.exception_code, modbus.read.address, modbus.read.quantity, modbus.write.address, modbus.write.quantity and modbus.write.value, with negation, range and direction-pinned cases. modbus-keywords reuses the modbus test pcap. modbus-keywords-write uses a synthetic pcap (generator included) with multiple-write, mask-write and single-write transactions, checking that modbus.write.quantity matches the quantity echoed in multiple-write responses and that modbus.write.value does not. Ticket: #8131.
Cover the code names accepted by modbus.function, modbus.subfunction and modbus.exception_code alongside the numeric values they stand for. Every name is paired with the numeric rule it should behave like, so each pair is expected to alert the same number of times. The pairs also cover lower and upper case spellings and a negated name. Reuses the modbus test pcap. Ticket: #8131.
akekulip
force-pushed
the
modbus-keywords-8131-v1
branch
from
September 21, 2026 15:11
e776f48 to
a02929a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for the modbus per-value detection keywords added in OISF/suricata#15960.
Ticket: https://redmine.openinfosecfoundation.org/issues/8131