detect/firewall: fix later LTE rule confusing policy checks - #16156
Draft
victorjulien wants to merge 1 commit into
Draft
victorjulien wants to merge 1 commit into
victorjulien wants to merge 1 commit into
Conversation
Handle cases where a non-matching rule followed later by an LTE rule
with a overlapping progress still work correctly.
E.g.:
drop:flow tls:client_hello_done .. tls.sni; content:"match" \
content:"no-match";
accept:flow tls:<client_hello_done .. tls.sni; content:"match"
In this case the `tls:client_in_progress` state needs to be accepted by
the 2nd rule, which acts as `accept:hook` on that state.
Additionally make sure that LTE rules that do not match their "main"
condition, are treated as the final CANT_MATCH.
Ticket: OISF#8944.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16156 +/- ##
=======================================
Coverage 83.11% 83.12%
=======================================
Files 1004 1004
Lines 277558 277597 +39
=======================================
+ Hits 230692 230745 +53
+ Misses 46866 46852 -14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
Information: QA ran without warnings. Pipeline = 33605 |
Contributor
|
Why is this a draft ? |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle cases where a non-matching rule followed later by an LTE rule with a overlapping progress still work correctly.
E.g.:
In this case the
tls:client_in_progressstate needs to be accepted by the 2nd rule, which acts asaccept:hookon that state.Additionally make sure that LTE rules that do not match their "main" condition, are treated as the final CANT_MATCH.
Ticket: #8944.
SV_BRANCH=OISF/suricata-verify#3343