Repository navigation
Conf sys update - #16374
Open
regit wants to merge 2 commits into
Open
Conf sys update#16374regit wants to merge 2 commits into
regit wants to merge 2 commits into
Conversation
A YAML sequence of single key maps, such as `outputs`, stores its entries at outputs.<n>.<name> so a direct lookup of outputs.<name> never matches. Add SCConfNodeLookupInSequence() to walk such a sequence and return the entries matching a given name. Ticket: 8606
In the case of --set=foo.0=bar, the 0 was not creating a sequence if ever the sequence is not existing. Ticket: 8606
victorjulien
reviewed
Oct 6, 2026
| node->final = final; | ||
| TAILQ_INSERT_TAIL(&parent->head, node, next); | ||
|
|
||
| /* Numeric-only key implies the parent is a sequence (yaml |
Member
There was a problem hiding this comment.
AI tells me numeric keys are allowed in yaml, so this would break that.
suricata-review-bot
left a comment
suricata-review-bot
left a comment
There was a problem hiding this comment.
AI-generated review.
Verdict: approve
No high- or medium-severity findings.
Automated at commit 460a7f9615eb using Codex with gpt-6-astra/xhigh. Run: 2bf8301e00ba308b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update of conf system spotted during the making of #16005
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8606
Describe changes: