ci: add system-map auto-sync caller (ORO-1936) - #252
Merged
Conversation
shardi-b
approved these changes
Aug 18, 2026
shardi-b
left a comment
Contributor
There was a problem hiding this comment.
Reviewed PR #252 (ci: add system-map auto-sync caller), a single new 27-line workflow at .github/workflows/system-map.yml, at high effort across all 8 finder angles (correctness, removed-behavior, cross-file, reuse, simplification, efficiency, altitude, conventions).
The workflow is well-constructed and I found no blocking issues:
- The fork gate
if: github.event.pull_request.head.repo.fork == falsecorrectly skips fork PRs (where theMAP_SYNC_PATsecret would be empty) while allowing internal branch PRs. - The reusable workflow is SHA-pinned (
@3bf228bc...), matching the stated supply-chain-safety intent. - Permissions (
contents: read,pull-requests: read) are genuinely least-privilege: the caller'sGITHUB_TOKENonly needs read access so the dispatcher can regenerate the map, while the cross-repo PR creation inoro-system-mapuses the separateMAP_SYNC_PAT. No scope is missing. - Passing
MAP_SYNC_PAT: ${{ secrets.MAP_SYNC_PAT }}is safe when the secret is absent (resolves to empty string, no error); the "no-op until secret present" behavior lives in the dispatcher, which is out of scope for this diff. - Trigger types
[opened, synchronize, reopened]onmainare standard and correct.
No finding scores 80 or above. Approving. (Note: the dispatcher sync-system-map.yml in ORO-AI/.github is not part of this diff and was not reviewed; the caller correctly delegates to it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the system-map auto-sync workflow (ORO-1936) for the validator layer. On any PR to
main, hands off to the shared dispatcher inORO-AI/.github(SHA-pinned), which regenerates the validator layer oforo-system-mapand opens an auto-merging sync PR there. Least-privilege permissions, fork-gated, explicitMAP_SYNC_PATsecret. No-op until the secret is present.