Skip to content

ci: unpin system-map caller — track .github@main (ORO-1936) - #253

Merged
that-guy-wade merged 1 commit into
mainfrom
oro-1936-unpin-caller
Aug 18, 2026
Merged

ci: unpin system-map caller — track .github@main (ORO-1936)#253
that-guy-wade merged 1 commit into
mainfrom
oro-1936-unpin-caller

Conversation

@that-guy-wade

Copy link
Copy Markdown
Contributor

Follow-up: the dispatcher is a first-party, branch-protected reusable workflow, so SHA-pinning the caller only added re-pin toil. Track ORO-AI/.github@main instead — dispatcher changes (the empty-PAT guard + toJSON payload hardening) now apply automatically.

@that-guy-wade
that-guy-wade requested a review from shardi-b August 18, 2026 16:42

@shardi-b shardi-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of PR #253ci: track ORO-AI/.github@main for system-map caller

Scope: Single file, .github/workflows/system-map.yml, +3/-4 lines. The functional change replaces the pinned reusable-workflow reference uses: ORO-AI/.github/.github/workflows/sync-system-map.yml@3bf228bc48733185867f30db9a5c53c86d98bea4 with @main, and rewrites the header comment to explain that the caller now tracks the branch-protected first-party dispatcher repo instead of a pinned SHA.

Correctness: No defects found. The on: triggers, the least-privilege permissions: block, the fork-skip guard (if: github.event.pull_request.head.repo.fork == false), and the secrets: MAP_SYNC_PAT forwarding are all unchanged. The @main ref is a valid reusable-workflow reference and behaves identically at call time to the previous SHA pin. No inverted conditions, no dropped guards, no syntax errors, and no call-site breakage.

Non-blocking note (supply-chain): Moving from a pinned SHA to a mutable @main ref while continuing to forward the MAP_SYNC_PAT secret does technically widen the trust surface — a compromise of, or unauthorized push to, main of ORO-AI/.github could alter the reusable workflow and exfiltrate the PAT across every mapped caller repo. That said, this is a deliberate, self-documented tradeoff for a first-party, branch-protected repo (avoiding a per-caller SHA bump on every dispatcher change), which is an accepted org-internal practice. It does not constitute a blocking defect.

Decision: No finding scores 80 or above. Approve.

@that-guy-wade
that-guy-wade merged commit 7f80247 into main Aug 18, 2026
2 checks passed
@that-guy-wade
that-guy-wade deleted the oro-1936-unpin-caller branch August 18, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants