Repository navigation
Prune unused imports before rendering files - #21
Merged
Merged
Conversation
prestonvanloon
approved these changes
Oct 2, 2026
Member
Author
|
It would be nice if we can include this after #22 got merged. |
syjn99
force-pushed
the
feat/emit-unused-imports
branch
from
October 26, 2026 09:09
5c39216 to
b7fcc87
Compare
syjn99
force-pushed
the
feat/emit-unused-imports
branch
from
October 26, 2026 09:12
b7fcc87 to
fa7f39a
Compare
Member
Author
|
Force-pushed because the base branch ( |
1 task done
syjn99
added a commit
to syjn99/prysm
that referenced
this pull request
Oct 29, 2026
**What does this PR do? Why is it needed?** This PR updates `methodical-ssz` version to [`c3f77ce44447`](https://github.com/OffchainLabs/methodical-ssz/tree/c3f77ce4444791c8d75cb950c8324f482ebebbed) which includes these three PRs: - OffchainLabs/methodical-ssz#22: Mostly worked by Kasey on Progression merkleization support. This version is already used in our production path (`932cc738`). - OffchainLabs/methodical-ssz#23: Needed for EIP-8015 and Decoupled consensus work. This fixes an issue when we have "inactive" fields in the progressive container. - OffchainLabs/methodical-ssz#21: Unlocks SSZ Engine work. **Which issue does this PR fix?** N/A **Other notes for review** The diff in this PR, except dependency changes, is ALL comment changes. Now generated codes for computing HTR of the progressive container denote `Field` to `Position` which is much more accurate. No functional changes intended as there is no "inactive" fields in Fulu/Gloas. **Acknowledgement** - [x] I have read [CONTRIBUTING.md](https://github.com/OffchainLabs/prysm/blob/develop/CONTRIBUTING.md) and my PR follows its checklist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultSSZImportsasserts thatencoding/binaryis always used, but it's not true when there's no integer fields for SSZ objects. While working on SSZ Engine, newly defined SSZ objects don't have an integer field at all, making compile error when the files are generated using methodical.Instead of pruning the unused one in downstream (which is Prysm), I'd rather submitted a change for methodical which is this PR. This PR prunes the entries of imports when they aren't referenced.