Repository navigation
Conversation
d53d064 to
b54226f
Compare
No really, the answer will be how we are going to maintain this from now onwards. If I can't review this, I can't say I'll be able to maintain it. But looking at the site, there are some inconsistencies. E.g., projects that are not linked to their section, links have disappeared from some pages like news. |
How do you maintain it now? Have you reviewed the entire source code in this repo?
Which projects have disappeared? Do you mean "2018 August 14: GSoC - End of Coding from news?", I deleted it. |
Replace the Jekyll build with an Astro 6 site built with Node 22 or newer, so the site no longer needs Ruby or the bootstrap-sass submodule. - Content now lives under src/content/: the GSoC ideas and guides in pages/gsoc/ (from _projects/ and gsoc/) and the news posts in posts/ (from _posts/). Most files are edited as they move. - Logos and backgrounds move from img/ to src/assets/, and CNAME and .well-known/ move to public/. - Astro layouts and components and three plain stylesheets replace the Liquid layouts, includes, plugin and Sass. - The contributor blog pages at /universe-oa/ are built by this site. - ESLint, Prettier, markdownlint, type checking, unit tests and a link checker run in a GitHub Actions workflow. CircleCI still builds the pull request preview. - The README is rewritten and CONTRIBUTING.md is new. This is the rewrite as it stood on 9 June 2026, squashed from 47 commits made since 25 January, three of them merges of upstream main.
- Deploy html/ to GitHub Pages from CI on main (keeps .well-known/matrix) - Redirect all old Jekyll URLs via a frozen map instead of 404ing - Restore /feed.xml, hotlinked /img/ logos, PyAstro and Calendar nav, FAQ advice - Fix home background 404, horizontal overflow on phones, strict frontmatter, and tsconfig so astro check sees content types
The CircleCI preview now rewrites root-relative and directory links itself, so every internal link no longer has to be threaded through pagePath.
seasons.yml is keyed by year and validated by a zod schema in content.config.ts. Drops universe-config.ts (and its ?raw YAML import), the yaml dependency and its npm override.
lychee (offline, fragments, index.html) gives the same result as scripts/linkcheck.mjs on this build; options live in lychee.toml.
Season pages no longer embed every project's full text in hidden dialogs, which removes duplicate ids, stray h1s and the page's only script. The standalone project page title is now its h1.
Six jobs each ran checkout, setup-node and npm ci for a two-second build. CI now uses .nvmrc, and push runs only on main (PRs run via pull_request).
Prettier rewrote ordinary mentor Markdown (every legacy idea file failed format:check). html/ is already ignored through .gitignore.
typescript-eslint and eslint-plugin-astro presets replace 54 hand-wired lines; drops the separate TS parser/plugin, astro-eslint-parser and eslint-config-prettier (ESLint 10 presets have no formatting rules).
totals, dateRanges, latestPostAt, feedUrl, post summaries and the unused fetcher/timeout options were never read; the RSS/Atom/RDF item lookup is one expression instead of three copies.
Placeholder filtering moves into stringListField, so buildProjectMeta reads the typed collection data directly; the member lookup reuses findMemberKey instead of a second cached copy. Build output is unchanged.
The ten season index.md files were identical boilerplate whose body was ignored. Also fixes season titles repeating the year.
Nothing read them (not even the old Jekyll layouts). Build output unchanged.
Removes rules that match nothing or repeat inherited values, merges the split .icon-envelope blocks, drops Icon's unused size prop, and stores the hamburger as one path so every icons.json entry has the same shape.
It shipped a 2.2 KB script to every page that never prefetched anything (no link opts in, and prefetchAll was off).
Both were small enough that Astro inlined them into every page that imported them (gsoc.css into all 174 catch-all pages). One cached 7 KB stylesheet now serves the whole site.
overflow-wrap: anywhere (added to stop phone overflow) let the table columns shrink mid-word; these tables already scroll sideways.
Replaces the JSDoc-on-every-export, one-describe-per-function and 40-line rules with a short list of conventions the code actually follows.
The page title became an h1 when the dialogs went; 11 idea bodies also started with a top-level heading (two repeated the title). Their headings move down a level, and the template no longer starts with one.
Two extra nav links made five labels wrap mid-label on desktop; labels now stay whole and the nav wraps as rows. The universe project logos keep their 24px width, and the archive keeps its old gap between seasons.
Portable sed -i.bak -E instead of perl; the legacy redirect stubs' meta refresh targets are prefixed too.
lychee now maps https://openastronomy.org/... links onto the build, so a broken absolute link to this site fails CI (sibling sites on the domain are excluded). The 404 page no longer declares a canonical URL. Dependabot opens npm security-fix PRs only; version updates stay manual.
- A contributor whose feed fails shows '? unknown' windows, not a row of misses; status pills get role=img so screen readers announce them - Feed titles decode ’-style entities; relative item links resolve against the feed; permalink <guid>s are used when <link> is missing; Atom rel=self links are never taken as the post URL - One getSeasons() helper for both pages fails the build on a non-year key or a current season without windows; contributor names must be non-blank and project keys must really be members.json keys (not 'constructor') - List-field normalisation moves to gsoc.ts as toStringList, with tests
- Every page now has its own meta description: members, news, the GSoC guides, the 2015/2016 idea lists, and projects (prefixed 'GSoC <year>:' because re-proposed ideas share their text) - The two background photos are served as ~20 kB WebP instead of 134 kB JPEG - /members/ keeps the old #who-is-part-of-openastronomy anchor; the old /img/icons/ images are back for any site still hotlinking them
- legacy-redirects.json keeps 23 entries (GSoC seasons and guides, news, the old posts, the 2015/2016 ideas indexes, Universe_OA) and drops the 146 /projects/*.html fragments and 11 per-org 2015/2016 ideas pages - Posts are served at /news/<file name>/, which removes the date-based route, src/lib/posts.ts and its tests; old post URLs redirect there and the feed keeps their old GUIDs - public/img keeps only the hotlinked logos (and member logos until the Universe_OA site is retired); the icons and the raster logo copy go
Content migrated first so the code can go (build output unchanged apart
from the dead IMS repo link and an id on the /gsoc/ heading):
- 26 collaborating_projects values lowercased to members.json keys, so the
case-insensitive member lookup goes
- 2 legacy list lines ('- None', a bare '-') removed, so list fields are
plain z.array(z.string()).nullish() instead of toStringList coercion
- 11 2015/2016 titles carry their year, so the runtime suffix goes
- gsoc/index.md has a body h1, so the Jekyll 'layout: page' branch goes
Unused compatibility code removed outright: RDF feeds and legacy date keys
(0 of 89 feeds), SourceForge and Bitbucket repo builders (the only
Bitbucket link, IMS, returns 404), post author/meta fields (never used),
null tolerance for fields no file leaves empty, and public/CNAME (read by
neither Pages mode).
- The no-JS phone menu fallback now works: a (scripting: none) media query in global.css replaces the <noscript> style, which lost the cascade - Home page gets an h1 (visually hidden; the logo is the visual title) and its hero logo loads eagerly with high priority again (it is the LCP image) - Project bodies start at ## instead of ####, so pages no longer jump from h1 to h4 (ids unchanged); list items get 4px spacing (target size) - Touch icon flattened onto white; 404 has no og:url and its own description; the phone menu closes when focus leaves it - Feeds: a 200 response that is not RSS/Atom counts as unavailable (shows '? unknown'); a guid is used only if it is already a full URL - Season checks move into a pure sortSeasons() with tests (no Astro runtime import in src/lib); error texts avoid Astro's misleading 'window' hint - Members: non-GitHub repositories must be full URLs (schema error names the member); sub-org guide documents repositories and the x handle - Content: curly apostrophe restored, Spectra.jl, CHIANTI link spacing, the dead APE 17 link, the sub-org guide's old h1 id - Node engines match the upgraded tools; linkcheck works from paths with spaces; .ncurc.json keeps npm-check-updates off TypeScript 7; the no-op Dependabot npm block is gone
Astro 7.3.5 to 7.4.13, ESLint 10.15, Prettier 3.10, Vitest 5.1, typescript-eslint 8.73, markdownlint-cli2 0.24, fast-xml-parser 5.12 and patch releases of the Astro plugins. All checks pass and the built HTML is unchanged. TypeScript stays on 6: @astrojs/check and typescript-eslint still reject 7.
- The prose 'li + li' margin also hit the member link list, so the first link in each card sat 4px above the others - Mentor and admin handles broke mid-word in 120px columns; columns are now at least 150px with 0.9rem text, so no handle on any season wraps - The page is a full-height flex column, so the footer sits at the bottom of short pages (404, news) instead of mid-screen
The default sort put every handle starting with a capital letter first (@Prtm2110 before @astrofrog).
- The stubs are build-only: astro dev returns 404 for them, so they need 'npm run build && npm run preview' to test - /Universe_OA/ is still served by the Universe_OA repository's own Pages site; the redirects for it only take over once that site is unpublished
Project ideas and prose pages shared one collection, so every field was optional and one route file told the two apart with a path regex. - Project files move from src/content/pages/gsoc/<year>/ to src/content/projects/<year>/ (147 renames; every URL is unchanged) and the template becomes src/content/projects/_template.md - The projects schema requires name, desc, difficulty, mentors and collaborating_projects; the pages schema requires title and description - src/pages/gsoc/[...project].astro renders projects, so [...slug].astro is prose-only; parseProjectId, the template filter in the route, the name fallback and the 'is it set?' branches in the components go - The one project that never had a desc (2017 fits-table-wcs) gets a one-line summary so the field can be required - Build output: 3 of 209 files change (that summary on two pages and the file path quoted in the sub-org guide)
They lived at /gsoc/<year>/ideas/ while every later season is at /gsoc/<year>/, which needed a year check in the blog archive. Renaming ideas.md to index.md makes all season URLs the same shape, so that check goes. The old Jekyll URLs (/gsoc/gsoc2015/ideas.html) redirect to the new location; /gsoc/<year>/ideas/ only ever existed in this rewrite.
The check remapped https://openastronomy.org/... to the build, which needed the same regex in package.json and ci.yml and a list of the other repositories' sites to exclude. Content has no absolute links to this site's own pages, so the remap only re-checked URLs the build generates. Root-relative and relative links and anchors are still checked (lychee 0.24.2: 0 errors, and a broken link and a missing anchor are both caught).
The feed looked up every post's old Jekyll URL in the redirect list to keep its old GUID, which tied the feed to legacy-redirects.json. Feed readers will show the four existing posts as new once.
Post bodies went into the feed with root-relative links and image paths (/gsoc/contributor_guidelines/, /img/...), which feed readers cannot resolve because they show the post outside this site.
Seven headings were raw HTML only to keep the old site's anchor ids, so they now get ordinary generated ids; an old deep link opens the right page at the top. 'Current Project ideas for GSoC 2026' becomes 'Current project ideas' so its anchor (linked from two guides) no longer changes every season, which also drops a step from the yearly update.
Every season marked its first window, and only that one, 'optional: true', and the schema existed to enforce exactly that. The window-status code now treats the first window as the optional one, so the flag leaves seasons.yml (6 lines) and the schema. Because position now carries the meaning, the schema checks that windows are in date order and do not overlap. The built page is unchanged.
Astro types Astro.props from a Props type declared in the frontmatter, so the eight 'Astro.props as Props' casts were redundant. PageLayout had no Props type at all, which let a mistyped prop through astro check; it now has one (and news.astro drops annotations the collection already infers).
Code that existed in two or three copies now has one home: - formatDate() in src/lib/dates.ts replaces three identical Intl.DateTimeFormat blocks (post layout, news list, contributor blogs) - CollaboratorList.astro replaces the same list markup in the project card and the project page - ProjectLabel.astro replaces the logo-and-name cell in both blog tables, and takes over the lookup that lived in member-logos.ts - The card rows are the detail rows plus the mentors, instead of a second copy of the list; the season page drops its positional 'sections' array The built HTML is identical.
- A key above the current season's table says what each mark means; before, that was only in hover tooltips, which touch screens lack - Below 700px each contributor is a stacked block instead of a 760px table that scrolled sideways with the status marks off-screen (the archive tables get the same treatment) - The prose list spacing now only applies to lists without a class, so interface lists such as the member links and this key need no reset
Astro's fonts config downloads the font during the build and serves it from /_astro/fonts/, so a visit makes no request to Google and the page no longer waits on a third-party stylesheet. The regular face is preloaded; the others load on demand. If Google Fonts is unreachable the build only warns and falls back to system fonts, so CI now fails when the font files are missing rather than publishing that.
The preview built on cimg/node:lts, which follows whatever Node release is the current LTS and is no longer the Node 24 that GitHub Actions takes from .nvmrc and that the deployed site is built with.
A description is printed straight after the member's name. Three did not read that way: 'Reltrans Reltrans (Relativistic...', 'radis A fast...' and 'Stingray : we are a team...'. They now start '(Relativistic...', 'is a fast...' and 'is a team...' (and radis loses 'a post-processing tools').
- .rounded-circle and .text-center were only used by the mentor and admin grid, which now styles its own avatars and text - feedErrorMessage() returned exactly what feedTitle() does for a failed feed
The live aggregator moved this contributor from Medium to Blogspot on 20 June (OpenAstronomy/Universe_OA ba2e749). The Medium feed still loads but holds one post from March, so every posting period showed as missing. The page now matches the live site for all five contributors.
Every network failure showed on the page as "Feed failed: fetch failed", because Node keeps the real reason on error.cause, and a timeout showed as "This operation was aborted". The page now says "Host not found", "Connection refused" or "Timed out after 6 s", and falls back to the cause's own message for anything rarer. AbortSignal.timeout() replaces the hand-rolled AbortController. It still covers reading the body, and its TimeoutError is what tells a timeout apart from other failures.
Each build judges the posting windows from what the feed lists at that moment, and feeds list only a blog's newest posts (10 on WordPress.com and Medium, 25 on Blogger). The old aggregator stored every post it collected, so a ✓ turning into ✕ for a frequent blogger is new behaviour. Also says what to do when a contributor moves blog, which is what left Omiii-215 with no posts.
Goals of this re-write are:
Non-ruby based build system.
Merging of the different systems that create the pages of the original site.
Removal of lots of css and javascript files.
Full liniting and unit tests with checks.
Full code documentation.
Updated Readme.
What has not changed:
AI was not used to update any of the website text.
That was all done by me.
Notes to Reviewers
I am not really expecting a full review since this changes all files in the repo.
I guess the answer is do you like the preview?
TODO: