fix: upload only available release packages, tolerate failed build jobs#151
Open
JackLau1222 wants to merge 3 commits into
Open
fix: upload only available release packages, tolerate failed build jobs#151JackLau1222 wants to merge 3 commits into
JackLau1222 wants to merge 3 commits into
Conversation
Use !cancelled() so upload-release runs even if individual builds fail. Build a dynamic file list from actually-downloaded artifacts instead of hardcoding all expected files. Skip upload if no packages exist.
Qt 6.7.0+ conditionally guards stdext namespace usage behind _MSC_VER < 1938, so MSVC 2022 17.8+ on windows-latest no longer trips over the deprecated stdext checked-iterator macros. Keep /permissive- since Qt's qglobal.h requires it via static_assert. Also bump arch from win64_msvc2019_64 to win64_msvc2022_64 to match the actual toolchain on the windows-latest runner.
Qt 6.7.3 win64_msvc2022_64 doesn't exist in the Qt online archives, causing aqt to fail with 'qt_base not found'. Qt 5.15.2 LTS is available and already used by the macOS CI build.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use !cancelled() so upload-release runs even if individual builds fail. Build a dynamic file list from actually-downloaded artifacts instead of hardcoding all expected files. Skip upload if no packages exist.