feat(cardwire-cli): add a cardwire launch program - #145
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CLI adds a ChangesGPU-aware launch
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI as cardwire CLI
participant DaemonClient
participant SwitcherooControl
participant Program as Requested program
CLI->>DaemonClient: get_gpu_switcheroo()
DaemonClient->>SwitcherooControl: Read GPUs property
SwitcherooControl-->>DaemonClient: GPU property maps
DaemonClient-->>CLI: GPU metadata
CLI->>Program: Launch with selected GPU environment and arguments
Program-->>CLI: Exit status
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/cardwire-cli/src/main.rs`:
- Around line 329-339: Update the launch command flow in main to return a
failure result when the child process exits unsuccessfully, command.status()
fails, no GPUs are found, or the --gpu selection matches no entry; preserve
successful execution as Ok(()) and propagate an appropriate error status for
each failure branch.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8d21780b-fc0d-452f-ba11-f0a8fd86e091
📒 Files selected for processing (3)
crates/cardwire-cli/src/args.rscrates/cardwire-cli/src/dbus.rscrates/cardwire-cli/src/main.rs
Description
Launch a program with cardwire ENVs using the switcheroo shim
TODO
Checklist: