Skip to content

feat(cardwired): default to hybrid mode instead of manual - #146

Merged
luytan merged 1 commit into
mainfrom
default-hybrid
Aug 5, 2026
Merged

feat(cardwired): default to hybrid mode instead of manual#146
luytan merged 1 commit into
mainfrom
default-hybrid

Conversation

@luytan

@luytan luytan commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Change the default mode from manual to hybrid for new installations

TODO

  • Copy-Paste this line

Checklist:

  • My code follows the style guidelines of this project (cargo fmt)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the mdBook documentation
  • My changes generate no new warnings (clippy/clang)
  • New and existing unit tests pass locally with my changes (either use nix flake check or wait for the ci)

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0e041410-1293-4314-ab0a-5f9405358829

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd38e9 and dbea4d7.

📒 Files selected for processing (2)
  • crates/cardwire-daemon/src/file/state.rs
  • crates/cardwire-daemon/src/interface/mode.rs

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated the app’s default mode to Hybrid instead of Manual.
    • Fixed default handling so new or empty configurations now start in Hybrid mode.
    • Aligned related checks so they reflect the new default behavior.

Walkthrough

The daemon now defaults Modes and CardwireModeState to Modes::Hybrid. Unit tests update the direct default and empty-JSON default expectations.

Changes

Hybrid mode default

Layer / File(s) Summary
Modes default variant
crates/cardwire-daemon/src/interface/mode.rs
The Modes enum now uses Hybrid as its default variant. Its unit test verifies the change.
State default propagation
crates/cardwire-daemon/src/file/state.rs
CardwireModeState::default() uses Modes::Hybrid. Tests verify direct and empty-JSON defaults.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title precisely describes the main change: switching the default mode from manual to hybrid mode in cardwired.
Description check ✅ Passed The description includes a summary of changes and covers all required checklist items, though lacks issue reference and feature motivation details.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@luytan
luytan merged commit ee2aefa into main Aug 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant