refactor(debian): remove unnecessary service management#6
Merged
Conversation
Signed-off-by: Elysia <a.elysia@proton.me>
jyxjjj
approved these changes
May 26, 2026
There was a problem hiding this comment.
Pull request overview
This PR refactors the Debian packaging to rely on debhelper’s dh_installsystemd for installing and managing the openlist.service unit, removing direct systemctl invocations and manual unit file staging. This aligns the packaging with standard Debian/Ubuntu systemd handling and addresses upgrade/unpack failures reported in #5.
Changes:
- Stop manually creating/installing the systemd unit file path during
override_dh_auto_install; install/manage the unit viadh_installsystemd. - Remove explicit service stop/enable/start/daemon-reload logic from
postinst,prerm, andpostrm, deferring to debhelper-generated maintainer script snippets. - Update
openlist.installcomments to reflect the new systemd-unit installation mechanism.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| debian/rules | Removes manual systemd unit staging and adds override_dh_installsystemd to install/manage the unit via debhelper. |
| debian/prerm | Drops manual service stop logic, leaving service handling to debhelper. |
| debian/postrm | Removes manual systemd cleanup on purge/remove, relying on debhelper-provided behavior. |
| debian/postinst | Removes direct systemctl enable/start/reload calls so debhelper manages service activation. |
| debian/openlist.install | Updates comments to reflect manual staging for binaries and debhelper-based systemd unit installation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using debhelper's dh_installsystemd to manage service files automatically.
This pr fixes #5