Repository navigation
Java/IoT3Mobility: fix Java compatibility and DENM issues - #590
Conversation
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Android users of the SDK have reported an incompatibility of the current helpers implementation with Android 31 (Java 8). Fix: out.toString(StandardCharsets.UTF_8) (Java 10) → new String(out.toByteArray(), StandardCharsets.UTF_8) Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Fix: value.isBlank() (Java 11) → value.trim().isEmpty() Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Fix: .toList() (Java 16) → .collect(Collectors.toList()) Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
The "private" or "unicast" DENM topic was not following the specified <topic_root>/outQueue/<sdk_uuid>/denm/+ structure. Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
There was a problem hiding this comment.
Hi. Do not understand why this change. Dinootoo says:
Si vous utilisez Java 11 ou plus récent, isBlank() est généralement plus fiable et plus simple pour vérifier si une chaîne est "vide ou uniquement blanche".
Si vous travaillez avec une version antérieure, vous devrez utiliser trim().isEmpty().
Did I miss something related to the version.
There was a problem hiding this comment.
Or maybe you want to ensure that after trim the lenght of the String t otest is 0?
There was a problem hiding this comment.
Actually we want compatibility with older Java versions for compatibility with some Android versions that are still very common, hence the use of this less optimized trim().isEmpty() instead of isBlank().
fredOG-2A1
left a comment
fredOG-2A1
left a comment
There was a problem hiding this comment.
Just an interrogation with the replacement of isBlank by trim().isEmpty.
What's new
A few fixes have been implemented:
situation,locationandalacartecontainers JSON fields are now correctly formattedClose #563
Close #564
Close #589
What to do
Review the code changes.