Repository navigation
Java/IoT3Core: Open telemetry improvements - #606
Merged
mathieu1fb merged 4 commits intoOct 5, 2026
Merged
Conversation
…5.3.2 BootstrapHelperTest have been updated to use mockwebserver3 for OkHttp v5 compatibility. Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
- OpenTelemetryClientTest for standalone OTLP tests - MqttClientOpenTelemetryTest for validation of MqttClient's OTLP integration behavior Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
…metry singleton causing issue with IoT3Core restart OpenTelemetryClient called GlobalOpenTelemetry.set()/resetForTest(), a process-wide singleton that throws IllegalStateException if set twice. Since nothing actually required the global instance (propagators were only ever read by MqttClient, which already holds a direct reference to the OpenTelemetryClient instance), this made stopping/restarting the SDK fail. Fix: keep propagators as instance state on OpenTelemetryClient (new getPropagators() accessor) and have MqttClient use it directly instead of GlobalOpenTelemetry, removing all reliance on global static state. Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
fredOG-2A1
approved these changes
Oct 5, 2026
fredOG-2A1
left a comment
fredOG-2A1
left a comment
Member
There was a problem hiding this comment.
Review done.
All Junit tests ran without any errors .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
opentelemetry-exporter's versionGlobalOpenTelemetrypropagators has been removed, with the localopenTelemetryClientnow exposing its own propagatorsOpenTelemetryClientand its usage byMqttClientClose #605
What to do
Review code and run all IoT3Core unit tests.