Set MenuItem.Id from AdminNode.UniqueId in the admin node navigation builders - #19771
JesseRigon wants to merge 1 commit into
Conversation
…builders ContentTypesAdminNode and ListsAdminNode expand one node into many menu items, so their Ids are qualified with the content type name and content item id respectively to stay unique per built item.
|
@dotnet-policy-service agree |
|
@Piedone, why has the First Time Contributor step failed? |
|
I don't know. |
|
We might need to check if this works after we updated in #19583 |
|
I'm just wondering if there is any issue with merging this change structurally or if this is just being deferred because one of the checks didn't pass. Just wanted to point out that check isn't anything to do with the changes I'm proposing. Any clarification would be appreciated. I know with Harvest, the team is busy. I'm just hoping to know where I stand. I'm working on a project that requires this change and so I'm having to use a custom implementation of orchardcore that I need to keep up to date with changes on main. Not the biggest deal in the world, but I would prefer not to if I could of course. |
…Id, PR #19771) Crest pins OrchardCore packages to 3.0.2-local, which only resolves from a feed packed from jesse-forked/OrchardCore branch Crest until OrchardCMS/OrchardCore#19771 merges. The note explains the pin, that the HOST decides the package source, and points at OrchardCore.Crest.Host for the working bootstrap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…atically - modules/OrchardCore: the jesse-forked/OrchardCore submodule (branch Crest, AdminNode UniqueId changes pending upstream in OrchardCMS/OrchardCore#19771) now lives alongside modules/OrchardCore.Crest instead of at the repo root. - dev/dev.sh: 'up'/'build' now guarantee an OrchardCore 3.0.2-local feed - the prebuilt sibling /workspaces/local-nuget-feed when present (dev layout), otherwise the fork submodule is initialized and packed into the gitignored in-repo local-nuget-feed/ (standalone layout). New 'feed' command forces the pack. Solution file is OrchardCore.slnx. - NuGet.config: map OrchardCore* to both feed folders; carve OrchardCore.Translations* out to nuget.org (real published packages, never in the monorepo feed - standalone restore failed NU1101 without it). - README: document the custom-OrchardCore requirement and both layouts. - Crest d777880: README fork-requirement note. Validated: dev-mode build green; forced 'feed' pack produced 446 packages byte-identical in file list to the sibling feed; standalone restore (cold cache, in-repo feed only) succeeds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
@all-contributors please add @JesseRigon for code. |
|
I've put up a pull request to add @JesseRigon! 🎉 |
|
Mistaken, sorry. |
Thank you very much |
|
@JesseRigon already contributed before to code |
This branch has not been deployed
3 participants
This sets Id from UniqueId in the four admin node builders.
MenuItem.Id was previously null for these items, and NavigationManager.Merge continues to match on Text.Name regardless of whether Id is set. Nodes become targetable by templates via the existing NavigationItemText_Id__{Id} alternates, the same way provider items already are.
ContentTypesAdminNode and ListsAdminNode expand one node into many items, so their Ids are qualified with the content type name / content item id to stay unique per built item while remaining stable when display names change.
There was a discussion opened for this #19731 for more detail.