Skip to content

ROU-12913: ButtonLoading - Adding new API method ForceIsLoadingDisabledState - #1183

Merged
joselrio merged 1 commit into
devfrom
ROU-12913
Jul 24, 2026
Merged

ROU-12913: ButtonLoading - Adding new API method ForceIsLoadingDisabledState#1183
joselrio merged 1 commit into
devfrom
ROU-12913

Conversation

@joselrio

Copy link
Copy Markdown
Contributor

This pull request introduces a new feature that allows developers to control whether the disabled attribute is managed on the button element when the ButtonLoading pattern is in a loading state. It also exposes a new API method for toggling this behavior, updates the interface and error codes accordingly, and makes a minor update to the SCSS versioning.

New feature: Manage disabled attribute on loading

  • Added a private flag _disableBtnWhenIsLoading and related logic in ButtonLoading.ts to control whether the button is automatically disabled when loading (IsLoading). This is now handled by the _setButtonDisabled method, which is called whenever the loading state changes. [1] [2]
  • Introduced a public method disabledStateOnIsLoading(isDisabled: boolean) to allow toggling this behavior at runtime.
  • Updated the IButtonLoading interface to include the new method for controlling the disabled state management.
  • Added a new property ManageDisabledAttribute to the ButtonLoading enum for future extensibility.

API and error code updates

  • Added a new API function ForceIsLoadingDisabledState in ButtonLoadingAPI.ts to allow external consumers to enable or disable automatic management of the disabled attribute.
  • Introduced a new error code FailForceDisabledStateOnIsLoading for error handling in the new API.

Other changes

  • Removed the CSS rule that set pointer-events: none on all elements during loading in _button-loading.scss, which may affect interaction with child elements.
  • Updated the OutSystems UI version comment in O11.OutSystemsUI.scss and ODC.OutSystemsUI.scss to 2.30.0. [1] [2]

@joselrio
joselrio requested a review from a team as a code owner July 23, 2026 14:17
@joselrio joselrio added enhancement New feature or request chore labels Jul 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@joselrio
joselrio merged commit 27850f0 into dev Jul 24, 2026
22 of 23 checks passed
@joselrio
joselrio deleted the ROU-12913 branch July 24, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants