ROU-12937: Fix Carousel removeChild NotFoundError on data refresh

[gnbm]

What was happening

On O11 and ODC, a Carousel with bare <img> slides crashed with NotFoundError: Failed to execute 'removeChild' on 'Node' (OS-CLRT-60500) when a ParameterOnChange action re-executed an aggregate feeding the carousel (and an IF around it).

Regressed in v2.29.0 by commit c30702391 (PR #1138, ROU-12567): _prepareCarouselItems() started reparenting bare <img> slides into a newly created wrapper <div>:

if (item.tagName === 'IMG') {
    const wrapper = document.createElement(...Div);
    item.replaceWith(wrapper);   // moves a platform-owned node
    wrapper.appendChild(item);
    wrapper.classList.add(Enum.CssClass.SplideSlide);
}

The <img> is a platform-owned node. On O11 and ODC, the runtime is React; moving it invalidates React's fiber record of the node's parent, so the next reconcile (triggered by the aggregate refresh) calls parent.removeChild(img) against a parent that no longer contains it → throw. Every provider redraw() re-ran this and re-wrapped the fresh nodes, making it self-sustaining.

What was done

Stop reparenting and keep the ARIA roles valid without moving any DOM — 3 changes in Splide.ts:

1. _prepareCarouselItems() — restored the pre-regression class-add loop: every item (incl. <img>) just gets the splide__slide class; no node is created or moved. Kept the Array.from snapshot.
2. _applyListRoles() — skip list semantics when the list has bare <img> slides: a role="list" whose children aren't list items is invalid ARIA, and an image can't take role="listitem" without losing its image semantics. Also drops a role="list" left from a previous pass when content changes across platform refreshes. The images stay exposed to screen readers via their alt text.
3. _setListRoles() — strip the role Splide assigns to a bare <img> slide: role="presentation" is valid on an image but removes it from the accessibility tree, so stripping it keeps the image announced via its alt text. Also strip role="tabpanel" from slides that are native list elements (ul/ol/li), via a tagName check.

PR #1138's other improvements (WCAG pagination target size, list/listitem roles for non-img slides, root role="presentation") are preserved untouched.

Test Steps

1. Open the sample page
2. Go to the "Test Carousel OnParameterChanged" section.
3. Toggle the Test_Carousel_OnParameterChanged switch a few times (re-runs OnParametersChanged).
4. Before fix: NotFoundError … removeChild in the console. After fix: no error; carousel keeps rendering.

Screenshots

N.A.

Checklist

• tested locally
• documented the code
• clean all warnings and errors of eslint
• requires changes in OutSystems (if so, provide a module with changes)
• requires new sample page in OutSystems (if so, provide a module with changes)

[Copilot]

Pull request overview

Fixes a regression in the Carousel Splide provider where wrapping “bare” <img> slides caused React-driven platforms (O11/ODC) to throw NotFoundError: Failed to execute 'removeChild' on 'Node' during data refresh/reconcile, by ensuring no platform-owned nodes are reparented and by adjusting ARIA role handling for image-only slides.

Changes:

• Stop reparenting slide DOM nodes in _prepareCarouselItems() (class-only mutation; no wrapper insertion).
• Skip applying role="list" / role="listitem" when the Splide list contains bare <img> slides, and remove a previously-applied role="list" if content changes to images.
• Strip provider-assigned roles from bare <img> slides to keep image semantics exposed to assistive tech; remove role="tabpanel" only for native list elements (ul/ol/li) where list semantics should remain implicit.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud