Skip to content

Repository navigation

Use stable panel IDs for the editor layout #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Paaanaaamaaa wants to merge 1 commit into from
Closed

Use stable panel IDs for the editor layout #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Sources/OvEditor/layout.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ Pos=0,0
Size=1920,1080
Collapsed=0

[Window][Asset Browser##2]
[Window][Asset Browser##Asset Browser]
Pos=0,556
Size=354,524
Collapsed=0
DockId=0x0000000C,0

[Window][Hardware Info##3]
[Window][Hardware Info##Hardware Info]
Pos=1227,719
Size=313,361
Collapsed=0
Expand Down Expand Up @@ -80,31 +80,31 @@ Size=1162,589
Collapsed=0
DockId=0x00000001,1

[Window][Console##5]
[Window][Console##Console]
Pos=356,729
Size=776,351
Collapsed=0
DockId=0x00000016,0

[Window][Toolbar##11]
[Window][Toolbar##Toolbar]
Pos=356,24
Size=1094,76
Collapsed=0
DockId=0x00000003,0

[Window][Project Settings##13]
[Window][Project Settings##Project Settings]
Pos=1542,24
Size=378,1056
Collapsed=0
DockId=0x00000014,2

[Window][Material Editor##12]
[Window][Material Editor##Material Editor]
Pos=1452,24
Size=468,1056
Collapsed=0
DockId=0x00000014,1

[Window][Asset Properties##14]
[Window][Asset Properties##Asset Properties]
Pos=1542,24
Size=378,1056
Collapsed=0
Expand All @@ -122,25 +122,25 @@ Size=808,347
Collapsed=0
DockId=0x00000009,0

[Window][Hierarchy##7]
[Window][Hierarchy##Hierarchy]
Pos=0,24
Size=354,530
Collapsed=0
DockId=0x0000000B,0

[Window][Inspector##8]
[Window][Inspector##Inspector]
Pos=1452,24
Size=468,1056
Collapsed=0
DockId=0x00000014,0

[Window][Scene View##9]
[Window][Scene View##Scene View]
Pos=356,102
Size=1094,625
Collapsed=0
DockId=0x00000004,1

[Window][Game View##10]
[Window][Game View##Game View]
Pos=356,102
Size=1094,625
Collapsed=0
Expand Down Expand Up @@ -188,19 +188,19 @@ Size=263,347
Collapsed=0
DockId=0x00000009,2

[Window][Frame Info##4]
[Window][Frame Info##Frame Info]
Pos=1134,729
Size=316,351
Collapsed=0
DockId=0x0000001A,0

[Window][Asset View##6]
[Window][Asset View##Asset View]
Pos=1134,729
Size=316,351
Collapsed=0
DockId=0x0000001A,1

[Window][Texture Debugger##15]
[Window][Texture Debugger##Texture Debugger]
Pos=1227,719
Size=313,361
Collapsed=0
Expand Down
5 changes: 5 additions & 0 deletions Sources/OvUI/src/OvUI/Panels/PanelWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ OvUI::Panels::PanelWindow::PanelWindow(const std::string& p_name, bool p_opened,
m_opened(p_opened)
{
autoSize = p_floatingPanelSettings.autoSize;

//derive the ImGui window id from the panel name(instead of the global panel counter),
// so saved layouts donot depend on how many panels were created before this one
if (!name.empty())
m_panelID = "##" + name;
}

void OvUI::Panels::PanelWindow::Open()
Expand Down